Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

248/252 Improve RIT and Bandwidth adjustment using mouse wheel #253

Merged
merged 7 commits into from
Feb 20, 2024

Conversation

w7sst
Copy link
Owner

@w7sst w7sst commented Feb 19, 2024

Improve RIT and Bandwidth adjustment using mouse wheel.

@w7sst w7sst self-assigned this Feb 19, 2024
@w7sst w7sst linked an issue Feb 19, 2024 that may be closed by this pull request
@@ -971,13 +971,15 @@ procedure TMainForm.FormMouseWheelDown(Sender: TObject; Shift: TShiftState;
begin
if GetKeyState(VK_CONTROL) >= 0 then IncRit(1)
else if RunMode <> rmHst then SetBw(ComboBox2.ItemIndex-1);
Handled := true; // set Handled to prevent being called 3 times
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change has been applied in many forks over time. However, none of them had detected or fixed the problem of multiple events being handled for a single mouse wheel click/movement. By setting Handled=true, only one event is handled. This was important for smooth operation of Bandwidth control using the Cntl-key.

@w7sst w7sst requested a review from K6OK February 19, 2024 08:35
@f6fvy
Copy link
Collaborator

f6fvy commented Feb 19, 2024

If I remember correctly, I set a smaller RIT step for mouse wheel on purpose to be able to adjust more easily. I actually hacked a mouse to make it a "real VFO" in an enclosure and a knob, and and frequency changes with the knob were too abrupt. May I suggest to allow the user to set this step in (another) setting in the ini file ? ;-)

@w7sst
Copy link
Owner Author

w7sst commented Feb 19, 2024

If I remember correctly, I set a smaller RIT step for mouse wheel on purpose to be able to adjust more easily. I actually hacked a mouse to make it a "real VFO" in an enclosure and a knob, and and frequency changes with the knob were too abrupt. May I suggest to allow the user to set this step in (another) setting in the ini file ? ;-)

Thank you - good suggestion. I have implemented this as you suggested. See #248 for additional details.

@w7sst
Copy link
Owner Author

w7sst commented Feb 19, 2024

@f6fvy ,
Here is a link for this build, 1.84-pr4.

@w7sst w7sst mentioned this pull request Feb 19, 2024
21 tasks
@w7sst
Copy link
Owner Author

w7sst commented Feb 19, 2024

@f6fvy, first question...

Should we let the RitStepIncr setting apply to mouse wheel movements only? I currently have them both tied to the same override setting. Do you see an use case where the use would want separate control between arrow keys and mouse wheel?

@w7sst
Copy link
Owner Author

w7sst commented Feb 19, 2024

@f6fvy, second question...

Should I set the default value to 30 or 25, instead of 50Hz/step?

In your original comment, you implied how you wanted a smaller value for fine control.

If I remember correctly, I set a smaller RIT step for mouse wheel on purpose to be able to adjust more easily. I actually hacked a mouse to make it a "real VFO" in an enclosure and a knob, and and frequency changes with the knob were too abrupt. May I suggest to allow the user to set this step in (another) setting in the ini file ? ;-)

I'm wondering what a good default value would be. Initially I was matching the Up/Down arrow key movement. However, this does change from the previous release's behavior, which I think was 150Hz/step (50Hz/step times 3 events firing per mouse detent movement).

@f6fvy
Copy link
Collaborator

f6fvy commented Feb 19, 2024

1/ I don't think necessary to have two different settings because most of the time the user is used to using either the keys or the mouse. Once the method is selected, the user can adjust the step if the default doesn't suit him/her.

2/ The default value sounds good to me after testing your pre release 4. But other testers may have a different opinion.

@w7sst w7sst merged commit 546ede2 into main Feb 20, 2024
@scotthibbs scotthibbs mentioned this pull request Mar 18, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change mouse wheel RIT movement to +/- 50Hz per step
2 participants