Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CQ WPX - Dx Stations will not send a serial number of zero #232

Merged
merged 1 commit into from
Jan 31, 2024
Merged

CQ WPX - Dx Stations will not send a serial number of zero #232

merged 1 commit into from
Jan 31, 2024

Conversation

w7sst
Copy link
Owner

@w7sst w7sst commented Jan 30, 2024

No description provided.

@w7sst w7sst added this to the v1.83.1 - bug fix release milestone Jan 30, 2024
@w7sst w7sst requested review from scotthibbs and ct7aup January 30, 2024 01:17
@w7sst w7sst self-assigned this Jan 30, 2024
@w7sst w7sst linked an issue Jan 30, 2024 that may be closed by this pull request
CQ WPX; 0 is not a valid entry for the serial number #213
Closed
1 task
@w7sst
Copy link
Owner Author

w7sst commented Jan 30, 2024

hi @ct7aup,
I think you wrote this original code. The reported issue reported a zero being generated for a Dx Station. The Random() function will generate a number beginning with zero. So the fix was to add one.

@w7sst w7sst merged commit 22dff77 into main Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scotthibbs scotthibbs Awaiting requested review from scotthibbs

@ct7aup ct7aup Awaiting requested review from ct7aup

Assignees

@w7sst w7sst

Labels
None yet
Projects
None yet
Milestone
v1.84 - IARU HF World Championship Co...
Development

Successfully merging this pull request may close these issues.

CQ WPX; 0 is not a valid entry for the serial number
1 participant
@w7sst