rework user callsign handling, load call history file at runtime #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntime. - after user callsign edits, SetMyCall is called. - SetMyCall calls Tst.OnSetMyCall which will extract any contest-specific information (e.g. in ARRL DX Contest, US/CA stations work only DX and DX works only US/CA stations). - call history file is now loaded after the user starts the contest using the RUN button. This simplified the reload logic in case the user callsign had changed. - move logic from each derived call history reader into the base class TContest.OnContestPrepareToStart function.
|
PR looks good. |
|
Reopening the PR so it can be merged. |
|
Hi @Yagi-Berra , can you re-approve this PR, but not close it. thank you, Mike |
ct7aup
approved these changes
Nov 22, 2022
K6OK
approved these changes
Nov 23, 2022
w7sst
deleted the
133-refactor-rework-user-callsign-handling-call-history-file-loading
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactor step is necessary to prepare for dual exchange contests, including ARRL DX Contest (part of issue #62). Previous refactoring steps are covered in PR #132 and PR #125.
Changes in this PR include: