Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contest selection dropdown list should be sorted #49

Closed
1 task done
w7sst opened this issue Oct 9, 2022 · 0 comments · Fixed by #135
Closed
1 task done

Contest selection dropdown list should be sorted #49

w7sst opened this issue Oct 9, 2022 · 0 comments · Fixed by #135
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@w7sst
Copy link
Owner

w7sst commented Oct 9, 2022

Description

As part of the multi-contest implementation, the new Contest Selection dropdown list contains a menu of contest names. This list is current not sorted. We are currently using the contest enumeration value as a storage key in the MorseRunner.ini file and want this number to not change.

Steps To Reproduce

  1. When adding a new contest, we want to append the new contest to the end of the enumeration and contest definition table.
  2. This may cause the displayed menu to not be sorted. This is the case when adding CQ WW Contest.

Expected behavior

The dropdown list should be sorted.

Actual Behavior

We currently see declaration order, not sorted.

Reproduces how often

Always.

Version information

  • Morse Runner version: 1.80, plus a new contest (requires code modification to see the problem).
  • OS/Version: Windows 11

Additional context

  • Currently, the menu items are added directly to the SimContestCombo control in the Main.dfm file.
  • The menu items are stored in SimContestCombo.Items.

Implementation Ideas

The implementation will involving:

  • writing code to programmatically add the menu items to this list in a sorted order
  • tagging each menu item with a tag consisting of the contest identifier (the TSimContest enum value). Using a menu item tag will allow the menu items to be sorted.
  • This also technique will also allow future internationalization.

Can you help?

Please let us know if you are available to help. (replace '[ ]' with '[x]' to affirm)

  • Yes, I'm available to help test a solution to this problem.
@w7sst w7sst added bug Something isn't working help wanted Extra attention is needed labels Oct 9, 2022
@w7sst w7sst self-assigned this Nov 23, 2022
@w7sst w7sst linked a pull request Nov 23, 2022 that will close this issue
w7sst added a commit that referenced this issue Nov 23, 2022
Fixes #49 - contest names are sorted in dropdown list

- contest names are taken from ContestDefinitions table and added to
dropdown list.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant