Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve missing/invalid exchange error reporting #341

Closed
w7sst opened this issue Aug 24, 2024 · 1 comment · Fixed by #342
Closed

Improve missing/invalid exchange error reporting #341

w7sst opened this issue Aug 24, 2024 · 1 comment · Fixed by #342
Assignees
@w7sst
Labels
enhancement New feature or request

Comments

@w7sst
Copy link
Owner

w7sst commented Aug 24, 2024 •
edited
Loading

Summary

When running a simulation, entered exchange information may be incorrect when pressing the Enter key. In this case, the user may not know what is wrong with their entered exchange or what is missing. For simple exchanges, this is not a problem. However, contests using a complex exchange (e.g. ARRL Sweepstakes Contest), the missing or incorrect information is not easily recognized. This change will display a message showing the error condition.

Why

  • ease of use. Also matches N1MM behavior of reporting missing or invalid exchange information.
@w7sst w7sst added the enhancement New feature or request label Aug 24, 2024
@w7sst w7sst self-assigned this Aug 24, 2024
w7sst added a commit that referenced this issue Aug 24, 2024
@w7sst
Improve exchange error reporting #341
76c1442 
- Add TContest.CheckEnteredCallLength virtual function
- Add TContest.ValidateEnteredExchange virtual function
- return ExchError via ValidateEnteredExchange
- report Exchange error after hitting Enter
- callsigns must contain 3 or more characters.
@w7sst
Copy link
Owner Author

w7sst commented Aug 25, 2024

Below is a sample output after trying to Save a QSO containing an incomplete exchange. This example is from the upcoming ARRL Sweepstakes Contest. This error was displayed after entering an incomplete exchange and then forcing a Save QSO by pressing Shift-Enter.
image
To correct this issue, the user would add the missing A after 60. The complete exchange is 60 A 15 MN.

w7sst added a commit that referenced this issue Aug 25, 2024
@w7sst
Improve exchange error reporting #341
377d4d3 
- Add TContest.CheckEnteredCallLength virtual function
- Add TContest.ValidateEnteredExchange virtual function
- return ExchError via ValidateEnteredExchange
- report Exchange error after hitting Enter
- callsigns must contain 3 or more characters.
@w7sst w7sst linked a pull request Aug 25, 2024 that will close this issue
341 improve exchange error reporting #342
Merged
@w7sst w7sst mentioned this issue Aug 25, 2024
Merged
w7sst added a commit that referenced this issue Aug 25, 2024
@w7sst
341 improve exchange error reporting (#342)
659722d 
Improve exchange error reporting #341
- Add TContest.CheckEnteredCallLength virtual function
- Add TContest.ValidateEnteredExchange virtual function
- return ExchError via ValidateEnteredExchange
- report Exchange error after hitting Enter
- callsigns must contain 3 or more characters.

See example output in Issue #341.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@w7sst w7sst

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

341 improve exchange error reporting w7sst/MorseRunner
1 participant
@w7sst