Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor - move Exchange declarations/tables into common file #332

Closed
w7sst opened this issue Aug 20, 2024 · 0 comments · Fixed by #333
Closed

Refactor - move Exchange declarations/tables into common file #332

w7sst opened this issue Aug 20, 2024 · 0 comments · Fixed by #333
Assignees
@w7sst
Labels
technical debt code cleanup, refactoring, improve comments and/or design
Milestone
v1.85 - ARRL Swee...

Comments

@w7sst
Copy link
Owner

w7sst commented Aug 20, 2024 •
edited
Loading

Summary

In preparation for adding the ARRL Sweepstakes Contest, we need to move some code. This change will move Exchange declarations and tables into a common file.

The purpose is to separate this data to allow smaller units to be developed that can be independently unit testing (see #108). The ARRL Sweepstakes Contest will include an exchange parser which will be fully unit tested.
@w7sst w7sst added the technical debt code cleanup, refactoring, improve comments and/or design label Aug 20, 2024
@w7sst w7sst added this to the v1.85 - next release milestone Aug 20, 2024
@w7sst w7sst self-assigned this Aug 20, 2024
w7sst added a commit that referenced this issue Aug 21, 2024
@w7sst
Refactor - move Exchange definitions/tables (#332)
e9a9b90 
- move Exchange definitions and tables to a new file, ExchFields.pas
- Code was simply moved to new file, ExchFields.pas. No functional changes.
@w7sst w7sst linked a pull request Aug 21, 2024 that will close this issue
Refactor - move Exchange definitions/tables (#332) #333
Merged
w7sst added a commit that referenced this issue Aug 21, 2024
@w7sst
Refactor - move Exchange definitions/tables (#332) (#333)
0269ec4 
- move Exchange definitions and tables to a new file, ExchFields.pas
- Code was simply moved to new file, ExchFields.pas. No functional
changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@w7sst w7sst

Labels
technical debt code cleanup, refactoring, improve comments and/or design
Projects
None yet
Milestone
v1.85 - ARRL Sweepstakes Contest
Development

Successfully merging a pull request may close this issue.

Refactor - move Exchange definitions/tables (#332) w7sst/MorseRunner
1 participant
@w7sst