Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect DXCC Entity reported in status bar for some callsigns #236

Closed
w7sst opened this issue Feb 7, 2024 · 0 comments · Fixed by #237
Closed

Incorrect DXCC Entity reported in status bar for some callsigns #236

w7sst opened this issue Feb 7, 2024 · 0 comments · Fixed by #237
Assignees
@w7sst
Labels
bug Something isn't working
Milestone
v1.84 - IARU HF W...

Comments

@w7sst
Copy link
Owner

w7sst commented Feb 7, 2024

Description

The DXCC Entity for certain callsigns are not reported correctly in the status bar. This is a minor problem and does not affect overall operation.

Steps To Reproduce

  1. Start a contest.
  2. Some callsigns, when entered will display the wrong DXCC Entity. For example, FK8IK should be New Caledonia, not Chesterfield Is.
  3. Most of the errors where found with unit testing, not with the product.

Expected behavior

Display Continent/Entity in status bar matching entered callsign.

Actual Behavior

Sometimes the displayed information is wrong. Here are a few examples...

Call Displayed Should Be
FK8IK Chesterfield Is. New Caledonia
TO5GR Saint Martin France
4V0HQ Italy Haiti
RN2FX European Russia Kaliningrad

Reproduces how often

Not often. You will only see it if one of these types of call patterns are entered.

Version information

  • Morse Runner version: 1.81

Additional context

  • I see it when running additional test code. (I have a private branch)
@w7sst w7sst added the bug Something isn't working label Feb 7, 2024
@w7sst w7sst added this to the v1.83.1 - bug fix release milestone Feb 7, 2024
@w7sst w7sst self-assigned this Feb 7, 2024
w7sst added a commit that referenced this issue Feb 9, 2024
@w7sst
Better status bar messages with improved DXCC Entity lookup #236
533f04e 
Updates to ARRL.pas (DXCC list parser)
- do not sort the regular expression list. These are ordered and
  must be processed in reverse order.
- added code to skip comments
- when extracting the callsign's prefix, do not remove the trailing characters.
  (This was masking prefixes with a trailing character (e.g. <digit><char>).
- special case for KG4 (Guantanamo Bay). Turns out many US callsigns
  have KG4 prefix but are located in US. The convension used by many
  is to let the 2x1 or 2x3 forms of this prefix to be in US and let
  any 2x2 calls to be in Guantanamo Bay.

Updates to ARRL.LIST (DXCC list)...
- The prefix TO cannot be used for Guadeloupe, Mayotte, Saint Barthelemy
- The prefix TO cannot be used for Martinique, Austral I.,
- The prefix TX cannot be used for New Caledonia, Chesterfield Is.
- The prefix TX cannot be used for Clipperton I.
- The prefix TX cannot be used for French Polynesia, Marquesas Is.
- The prefix TO cannot be used for Reunion I., Glorioso Is., Juan de Nova
- The prefix TO cannot be used for Tromelin I., Saint Martin
- 4V was listed for Italy; it should be 4U.
- Greenland prefix changed to OX|XP; was P[XP].
- Remove Mount Athos (SV) since it was hiding Greece (includes SV)
- Kaliningrad was hiding European Russia; updated regular expression.
- The prefix VP8,LU cannot be used for South Georgia I.
- The prefix VP8,LU cannot be used for South Orkney Is.
- The prefix VP8,LU cannot be used for South Sandwich Is.
- The prefix VP8,LU cannot be used for South Shetland Is.
@w7sst w7sst linked a pull request Feb 9, 2024 that will close this issue
Better status bar messages with improved DXCC Entity lookup #236 #237
Merged
w7sst added a commit that referenced this issue Feb 12, 2024
@w7sst
Better status bar messages with improved DXCC Entity lookup #236 (#237)
eedd4af 
Updates to ARRL.pas (DXCC list parser)
- do not sort the regular expression list. These are ordered and must be
processed in reverse order.
- added code to skip comments
- when extracting the callsign's prefix, do not remove the trailing
characters. (This was masking prefixes with a trailing character (e.g.
<digit><char>).
- special case for KG4 (Guantanamo Bay). Turns out many US callsigns
have KG4 prefix but are located in US. The convension used by many is to
let the 2x1 or 2x3 forms of this prefix to be in US and let any 2x2
calls to be in Guantanamo Bay.

Updates to ARRL.LIST (DXCC list)...
- The prefix TO cannot be used for Guadeloupe, Mayotte, Saint Barthelemy
- The prefix TO cannot be used for Martinique, Austral I.,
- The prefix TX cannot be used for New Caledonia, Chesterfield Is.
- The prefix TX cannot be used for Clipperton I.
- The prefix TX cannot be used for French Polynesia, Marquesas Is.
- The prefix TO cannot be used for Reunion I., Glorioso Is., Juan de
Nova
- The prefix TO cannot be used for Tromelin I., Saint Martin
- 4V was listed for Italy; it should be 4U.
- Greenland prefix changed to OX|XP; was P[XP].
- Remove Mount Athos (SV) since it was hiding Greece (includes SV)
- Kaliningrad was hiding European Russia; updated regular expression.
- The prefix VP8,LU cannot be used for South Georgia I.
- The prefix VP8,LU cannot be used for South Orkney Is.
- The prefix VP8,LU cannot be used for South Sandwich Is.
- The prefix VP8,LU cannot be used for South Shetland Is.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@w7sst w7sst

Labels
bug Something isn't working
Projects
None yet
Milestone
v1.84 - IARU HF World Championship Co...
Development

Successfully merging a pull request may close this issue.

Better status bar messages with improved DXCC Entity lookup #236 w7sst/MorseRunner
1 participant
@w7sst