Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usability - Hide Dx Station's Entity status string if same as user's Entity #222

Closed
1 task done
w7sst opened this issue Jan 15, 2024 · 4 comments · Fixed by #223
Closed
1 task done

Usability - Hide Dx Station's Entity status string if same as user's Entity #222

w7sst opened this issue Jan 15, 2024 · 4 comments · Fixed by #223
Assignees
Labels
bug Something isn't working verified Bug is fixed and verified

Comments

@w7sst
Copy link
Owner

w7sst commented Jan 15, 2024

Description

It is not necessary to display the DxStation's Continent/Entity information when it matches the current user's Continent/Entity information. This occurs when the contest's history file does not contain the optional user text fields. For example, for a US station running a contest, when they work a US station and the call history file does not contain a user text field, the string ' - NA/United States of America'. In this case, the user has already recognized the callsign as a domestic call and the information in the status bar is not helpful nor interesting.

Steps To Reproduce

  1. Pick a contest (not K1USN SST)
  2. Set a US callsign for the current user
  3. Start Single Call mode
  4. work a few stations until you see 'NA/United States of America'

Expected behavior

I think it would be more interesting for the simulation to show Continent/Entity information for those callsigns that are not in the user's current Entity. Users will recognize callsigns from their current Entity.

Actual Behavior

Currently, when the callsign record from the history file does not contain a user text field, the DxStation's Continent/Entity is displayed.

Reproduces how often

Always.

Version information

  • Morse Runner version: 1.83
  • OS/Version: Windows 10

Additional context

Can you help?

  • Yes, I'm available to help test a solution to this problem.
@w7sst w7sst added the bug Something isn't working label Jan 15, 2024
@w7sst w7sst added this to the v1.83.1 - bug fix release milestone Jan 15, 2024
@w7sst w7sst self-assigned this Jan 15, 2024
@w7sst w7sst added the fixed - ready for validation bug is fixed; ready for validation label Feb 2, 2024
@w7sst
Copy link
Owner Author

w7sst commented Feb 2, 2024

Do you want to give this one a try?

@scotthibbs
Copy link
Collaborator

scotthibbs commented Feb 22, 2024

I'm not sure what I'm looking for here. I ran several contests and I'm still getting the NA/United States of America (below the log window) if I use my KD4SIR when I receive a domestic call. Please advise.

For the IARU HF contest I still see NA/USA. Also I think I got a south african station call correct (I got an "r") but I put SAL instead of SAF for the exchange and got a NIL error. Is this an issue?

@w7sst
Copy link
Owner Author

w7sst commented Feb 22, 2024

I think this was for the K1USN SST contest only. Sorry for the confusion and for my lack of detail in the notes.

@scotthibbs
Copy link
Collaborator

NP. I just ran the contest and I'm seeing the city and state of the responder. I'm not seeing NA or USA. I'm guessing that was as expected. Sorry I haven't been working this contest much.

@w7sst w7sst added verified Bug is fixed and verified and removed fixed - ready for validation bug is fixed; ready for validation labels Feb 23, 2024
@w7sst w7sst closed this as completed Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working verified Bug is fixed and verified
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants