Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor - add TStation.SetWpm; rename Wpm to WpmS (CW sending speed) #189

Closed
w7sst opened this issue Feb 25, 2023 · 0 comments · Fixed by #190
Closed

refactor - add TStation.SetWpm; rename Wpm to WpmS (CW sending speed) #189

w7sst opened this issue Feb 25, 2023 · 0 comments · Fixed by #190
Assignees
@w7sst
Labels
technical debt code cleanup, refactoring, improve comments and/or design
Milestone
v1.83 - CWT updat...

Comments

@w7sst
Copy link
Owner

w7sst commented Feb 25, 2023

As part of the introduction of Farnsworth CW timing support, issue #188, some refactoring was needed.

This issue will:

  • add TStation.SetWpm() function
  • rename existing Wpm variable to WpmS variable. This represents "words per minute" being sent.

This will allow introduction of the corresponding WpmC variable representing Farnsworth Character speed.
@w7sst w7sst added the technical debt code cleanup, refactoring, improve comments and/or design label Feb 25, 2023
@w7sst w7sst self-assigned this Feb 25, 2023
@w7sst w7sst mentioned this issue Feb 25, 2023
Merged
@w7sst w7sst linked a pull request Feb 25, 2023 that will close this issue
refactor - rename Wpm to WpmS (sending wpm speed); add TStation.SetWpm #190
Merged
w7sst added a commit that referenced this issue Feb 25, 2023
@w7sst
refactor - rename Wpm to WpmS (sending wpm speed); add TStation.SetWpm (
eba188f 
#190)

Renames existing Wpm variable to WpmS and adds TStation.SetWpm() method.

This is done in preparation for adding Farnsworth support in #188. Fixes
#189.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@w7sst w7sst

Labels
technical debt code cleanup, refactoring, improve comments and/or design
Projects
None yet
Milestone
v1.83 - CWT updates, SST, ALLJA/ACAG ...
Development

Successfully merging a pull request may close this issue.

refactor - rename Wpm to WpmS (sending wpm speed); add TStation.SetWpm w7sst/MorseRunner
1 participant
@w7sst