Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for JARL Major Contests #187

Closed
3 tasks
jr8ppg opened this issue Feb 25, 2023 · 2 comments · Fixed by #192
Closed
3 tasks

Add support for JARL Major Contests #187

jr8ppg opened this issue Feb 25, 2023 · 2 comments · Fixed by #192
Assignees
Labels
contest New contest request

Comments

@jr8ppg
Copy link
Collaborator

jr8ppg commented Feb 25, 2023

Contest information

Unique contest behaviors

  • ALL JA contest use prefecture codes for exchange number.
  • ACAG contest use city/gun(country) codes for exchange number.
  • In the JARL contest, a code that means power is added to the end of the exchange number.
    P is 5W oe less(QRP), L is 10W or less, M is 100W or less, H is greater than 100W.
  • Most of the rules of other contests held in Japan follow the rules of the ALLJA contest.

ALLJA examples

  • For 100W station in Tokyo
    599 10M
  • For 1KW station in Hokkaido Ishikari branch office
    599 106H

ACAG examples

  • For 100W station in Hachioji City, Tokyo
    599 1002M
  • For 1KW station in Chuo Ward, Sapporo City, Hokkaido
    599 010101H

Additional information

Can you help?

Please let us know if you are available to help. (replace '[ ]' with '[x]' to affirm)

  • Yes, I'm available to discuss questions or alternatives regarding the implementation of this contest.
  • Yes, I'd like to review and provide feedback on the proposed solution.
  • Yes, I'm available to help test this contest. Let me know when it is ready for early testing.
@jr8ppg jr8ppg added the contest New contest request label Feb 25, 2023
@w7sst
Copy link
Owner

w7sst commented Feb 27, 2023

Hi @jr8ppg ,
Congrats on your progress with the JARL Contests.

How can I help? Are you still making changes to this code? Please create a Pull Request when you are ready to start the code review. If you need help, let me know and I can create it for you. After the code review, I will merge the Pull Request.

Also, I noticed a memory leak in both of your new contests in the LoadCallHistory procedures. In the loop that is adding each CallRecord, if a continue message is executed, the object created by CallRecord.Create is lost. You can see the fix in the CWSST.pas file. Let me know if you want help with this and I can make the changes and merge back into your branch.

@jr8ppg
Copy link
Collaborator Author

jr8ppg commented Feb 27, 2023

Hi @w7sst

Thanks for your support.
I fixed the memory leak.
I will create a pull request so please review it.

@w7sst w7sst linked a pull request Feb 27, 2023 that will close this issue
jr8ppg added a commit that referenced this issue Feb 28, 2023
jr8ppg added a commit that referenced this issue Feb 28, 2023
jr8ppg added a commit that referenced this issue Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contest New contest request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants