Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CWOPTS.isnum() incorrectly considered an empty string as a valid number #18

Closed
w7sst opened this issue Sep 16, 2022 · 0 comments
Closed

CWOPTS.isnum() incorrectly considered an empty string as a valid number #18

w7sst opened this issue Sep 16, 2022 · 0 comments
Assignees
@w7sst
Labels
bug Something isn't working

Comments

@w7sst
Copy link
Owner

w7sst commented Sep 16, 2022

Description

CWOPTS.isnum() function will consider an empty string as a valid number.

Steps To Reproduce

I discovered this during interactive testing. I forgot the steps to reproduce.

Expected behavior

an empty string should be an invalid number. Function should return False.

Actual Behavior

incorrectly returns True (valid number).
@w7sst w7sst added the bug Something isn't working label Sep 16, 2022
@w7sst w7sst self-assigned this Sep 16, 2022
w7sst added a commit that referenced this issue Sep 16, 2022
@w7sst
Issue #18 - bug fix - CWOPTS.isnum() incorrectly considered an empty …
0e3e494 
…string as a valid number.
@w7sst w7sst mentioned this issue Sep 16, 2022
Merged
ct7aup added a commit that referenced this issue Sep 16, 2022
@ct7aup
Merge pull request #19 from w7sst/18-cwoptsisnum-incorrectly-consider…
5e5fb50 
…ed-an-empty-string-as-a-valid-number

Issue #18 - bug fix - CWOPTS.isnum() incorrectly considered an empty string as valid
@w7sst w7sst closed this as completed Sep 17, 2022
@scotthibbs scotthibbs mentioned this issue Oct 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@w7sst w7sst

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

18-cwoptsisnum-incorrectly-considered-an-empty-string-as-a-valid-number w7sst/MorseRunner
1 participant
@w7sst