Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exchange Resent After Editing Call #177

Closed
3 tasks done
Stingy49 opened this issue Feb 7, 2023 · 3 comments · Fixed by #179
Closed
3 tasks done

Exchange Resent After Editing Call #177

Stingy49 opened this issue Feb 7, 2023 · 3 comments · Fixed by #179
Labels
bug Something isn't working verified Bug is fixed and verified
Milestone
v1.83 - CWT updat...

Comments

@Stingy49
Copy link

Stingy49 commented Feb 7, 2023 •
edited by w7sst
Loading

Description

If I get a call wrong during CWOPS CWT (also ARRL FD, haven't tried others), instead of sending the corrected call followed by TU it sends the corrected call followed by my exchange again.

Steps To Reproduce

  1. Start CWOPS CWT
  2. Copy a call wrong (ex. K4AD instead of correctly copying K4AB)
  3. Fix call when other station sends DE K4AB name nr along with entering correct name and nr (doesn't matter if text cursor is in the name or nr field)
  4. Press enter

Expected behavior

You reply with the corrected call and TU. The QSO ends and is logged.

Actual Behavior

You reply with the corrected call but then follow with your exchange causing the other station to send their info again unnecessarily.

Reproduces how often

100%

Version information

1.82, 1.81, and 1.80 all exhibit the issue.

Additional context

Works correctly in 1.68

Can you help?

Please let us know if you are available to help. (replace '[ ]' with '[x]' to affirm)

  • Yes, I'm available to help test a solution to this problem.

Tasks

  • Post a pre-release build
  • Validate the bug fix
@Stingy49 Stingy49 added the bug Something isn't working label Feb 7, 2023
@w7sst w7sst mentioned this issue Feb 8, 2023
Merged
@w7sst w7sst linked a pull request Feb 8, 2023 that will close this issue
After correcting a copied callsign, TU is now sent #179
Merged
@w7sst
Copy link
Owner

w7sst commented Feb 9, 2023

This problem was also reported by John, K3TN, on groups.io. See https://groups.io/g/MorseRunnerCE/topic/difference_in_operating/96249040.

w7sst added a commit that referenced this issue Feb 10, 2023
@w7sst
After correcting a copied callsign, TU is now sent (#179)
f305bb4 
Previously, after correcting a copied callsign, MR would send the
corrected callsign along with the full exchange. Now MR will send the
corrected callsign followed by 'TU'. This fixes #177.

This bug was inserted while building ARRL FD and has been mostly backed
out.
@w7sst w7sst added the fixed - ready for validation bug is fixed; ready for validation label Feb 10, 2023
@w7sst w7sst reopened this Feb 26, 2023
@w7sst
Copy link
Owner

w7sst commented Feb 26, 2023

I have posted MR v1.83-pr2 Pre-Release build here. Please reset this bug and comment below after validating the fix.

@Stingy49 @scotthibbs

@Stingy49
Copy link
Author

@w7sst Works great for me!

@w7sst w7sst added verified Bug is fixed and verified and removed fixed - ready for validation bug is fixed; ready for validation labels Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working verified Bug is fixed and verified
Projects
None yet
Milestone
v1.83 - CWT updates, SST, ALLJA/ACAG ...
Development

Successfully merging a pull request may close this issue.

After correcting a copied callsign, TU is now sent w7sst/MorseRunner
2 participants
@Stingy49 @w7sst