Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix memory leak in CWOPS CWT file history reader #147

Closed
w7sst opened this issue Nov 30, 2022 · 0 comments · Fixed by #148
Closed

Fix memory leak in CWOPS CWT file history reader #147

w7sst opened this issue Nov 30, 2022 · 0 comments · Fixed by #148
Assignees
@w7sst
Labels
bug Something isn't working
Milestone
v1.82 - larger us...

Comments

@w7sst
Copy link
Owner

w7sst commented Nov 30, 2022

Description

When the CWT history file is processed, a new TCWOPSRec object is allocated within a while loop. However, some records are ignored and a continue occurs. The object is reallocated.

Steps To Reproduce

Can be seen via code review or in the debugger.

Expected behavior

No memory leak.

Actual Behavior

We drop objects.

Reproduces how often

100%

Version information

  • Morse Runner version: latest
  • OS/Version: Windows 11
@w7sst w7sst added the bug Something isn't working label Nov 30, 2022
@w7sst w7sst self-assigned this Nov 30, 2022
w7sst added a commit that referenced this issue Nov 30, 2022
@w7sst
fix #147 - memory leak in CWOPS call history reader
7a36d98
@w7sst w7sst linked a pull request Nov 30, 2022 that will close this issue
fix #147 - memory leak in CWOPS call history reader #148
Merged
w7sst added a commit that referenced this issue Dec 1, 2022
@w7sst
errors in ARRL DXCC ARRL.LIST file (Coded by W7SST)
392df94 
- updated to March 2022 edition
- https://www.arrl.org/files/file/DXCC/2022_DXCC_Current.pdf
- Z6 was missing
- many entries had incorrect regular expression values
- fixes #147
@w7sst w7sst mentioned this issue Dec 1, 2022
Merged
@w7sst w7sst closed this as completed in #148 Dec 3, 2022
w7sst added a commit that referenced this issue Dec 3, 2022
@w7sst
fix #147 - memory leak in CWOPS call history reader (#148)
1055437
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@w7sst w7sst

Labels
bug Something isn't working
Projects
None yet
Milestone
v1.82 - larger user-group announcement
Development

Successfully merging a pull request may close this issue.

fix #147 - memory leak in CWOPS call history reader w7sst/MorseRunner
1 participant
@w7sst