Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand on Snowfork content on Bridge Hub page #6167

Merged
merged 14 commits into from
Aug 28, 2024
Merged

Conversation

CrackTheCode016
Copy link
Contributor

Addresses mega issue #6085

Expand on Snowfork content on Bridge Hub page

@CrackTheCode016 CrackTheCode016 added the A1 - In Progress Not ready for review yet. label Aug 21, 2024
@CrackTheCode016 CrackTheCode016 added A2 - Please Review Pull request is ready for review. and removed A1 - In Progress Not ready for review yet. labels Aug 27, 2024
@CrackTheCode016
Copy link
Contributor Author

Left it pretty simple, mostly pointing towards Snowbridge's documentation and summarizing its features.

Copy link
Contributor

@filippoweb3 filippoweb3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR. I think we can add the page to the Wiki although the snowbridge page can benefit from additional information about how the Ethereum state is kept up-to-date on Polkadot. This can be done on a separate PR later on :)

docs/learn/learn-bridge-hub.md Outdated Show resolved Hide resolved
@@ -25,6 +29,11 @@ A two-way trustless bridge between chains A and B can be viewed as two one-way b
source and a target chain. Any bridge operating on the Bridge Hub will have on-chain (pallets) and
offchain (relayers) components.

Examples of trustless on Bridge Hub include:

- Snowfork, a decentralized bridge between Polkadot and Ethereum
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we specify that this is an Ethereum light client on Polkadot that syncs to Ethereum and keeps the Ethereum state up-to-date on Polkadot?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this is good for the next PR, we can add those details in the followup 👍

docs/learn/learn-bridge-hub.md Outdated Show resolved Hide resolved
docs/learn/learn-bridge-hub.md Outdated Show resolved Hide resolved
docs/learn/learn-bridge-hub.md Outdated Show resolved Hide resolved
docs/learn/learn-bridge-hub.md Outdated Show resolved Hide resolved
docs/learn/learn-snowbridge.md Outdated Show resolved Hide resolved

Trustlessness here is defined in the sense that the users do not need to trust any particular
individuals or organizations, but rather only the mathematics, code, cryptography, and protocol. An
example of a system which implies a high level of trust **trust** would be that of a bridge which is
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
example of a system which implies a high level of trust **trust** would be that of a bridge which is
example of a system which implies a high level of **trust** would be that of a bridge, which is

docs/learn/learn-snowbridge.md Outdated Show resolved Hide resolved
docs/learn/learn-snowbridge.md Outdated Show resolved Hide resolved
@CrackTheCode016
Copy link
Contributor Author

@filippoweb3

although the snowbridge page can benefit from additional information about how the Ethereum state is kept up-to-date on Polkadot.

Good point, I was not sure whether I should go in more detail about the message passing and its architecture, I agree we can add in a separate PR.

@CrackTheCode016 CrackTheCode016 merged commit c0a9ded into master Aug 28, 2024
3 checks passed
@CrackTheCode016 CrackTheCode016 deleted the snowfork-content branch August 28, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A2 - Please Review Pull request is ready for review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants