Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coretime Guides Rework (Omninode Considerations) #5946

Merged
merged 18 commits into from
Sep 13, 2024

Conversation

CrackTheCode016
Copy link
Contributor

@CrackTheCode016 CrackTheCode016 commented Jun 6, 2024

Please note that these only affect the Kusama guides

Closes issue #5928


  • Add instructions for installing polkadot-parachain and chain-spec-builder
  • Replace using the compiled binary with polkadot-parachain as the "omninode"
  • Use chain-spec-builder as a means for the genesis

@CrackTheCode016 CrackTheCode016 added the A1 - In Progress Not ready for review yet. label Jun 6, 2024
@CrackTheCode016 CrackTheCode016 self-assigned this Jun 6, 2024
@CrackTheCode016
Copy link
Contributor Author

Will modify this guide once this is merged / resolved: paritytech/polkadot-sdk#4889

@CrackTheCode016 CrackTheCode016 added the Blocked Pending an update, fix or a third-party action label Jun 26, 2024
@@ -120,79 +175,27 @@ Feel free to copy the configuration below and use it to ensure everything is in
deployment. This function should replace the `local_testnet_config` function within
`node/src/chain_spec.rs`:

> **:warning: WARNING! :warning:** Make sure you replace the ParaId with the one you reserved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yesssss, happy to see all of this goes away now 😇

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is still some cleanup to do on my end, I mostly need to back around to the PR to allow for an easier way to generate parachain specs - although, it's just really modifying a JSON after generating it ATM, which isn't terrible, so I may push it with that extra manual step. WDYT?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree, I think editing a JSON file is well within the capabilities of anyone. It is not amazing devEx tho, but we can improve that next.

@CrackTheCode016 CrackTheCode016 removed the Blocked Pending an update, fix or a third-party action label Aug 7, 2024
@CrackTheCode016
Copy link
Contributor Author

Besides the trouble I am having with installing polkadot-parachain with cargo install, the updates to this guide should be sound and working.

There is still a lot of improvement to be made. For example, the steps should be broken down a little bit more into seperate pages for reserving, template-related items, and deploying. I don't think the final place for this guide - so this is a good stopping point.

@CrackTheCode016 CrackTheCode016 added A2 - Please Review Pull request is ready for review. and removed A1 - In Progress Not ready for review yet. labels Aug 21, 2024
@CrackTheCode016
Copy link
Contributor Author

The issues above have been fixed. Someone else should run through this guide and ensure it works - I tested most parts, but not a full deployment (yet).

There is still a good amount of work to improve this guide, but we can save that for docs.polkadot.com ;) This is a good stopping point for now that uses the latest versions and direction.

docs/build/build-guides-coretime-start.md Outdated Show resolved Hide resolved
docs/build/build-guides-coretime-start.md Outdated Show resolved Hide resolved
docs/build/build-guides-coretime-start.md Outdated Show resolved Hide resolved
docs/build/build-guides-coretime-start.md Outdated Show resolved Hide resolved
docs/build/build-guides-template-basic.md Outdated Show resolved Hide resolved
docs/build/build-guides-template-basic.md Outdated Show resolved Hide resolved
docs/build/build-guides-template-basic.md Outdated Show resolved Hide resolved
docs/build/build-guides-template-basic.md Outdated Show resolved Hide resolved
docs/build/build-guides-template-basic.md Outdated Show resolved Hide resolved
docs/build/build-guides-template-basic.md Outdated Show resolved Hide resolved
@CrackTheCode016
Copy link
Contributor Author

CrackTheCode016 commented Sep 13, 2024

@DrW3RK I think this guide is actually already out of date due to the following factors:

  • Rococo is being deprecated
  • chain-spec-builder should be parachain enabled (to some extent, still waiting for it to be included in a release)
  • Overall writing can be improved with what we've learned over the past months

Perhaps we work to merge this, then work on these updates? WDYT?

Copy link
Member

@DrW3RK DrW3RK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed

@CrackTheCode016 CrackTheCode016 merged commit 49011a5 into master Sep 13, 2024
3 checks passed
@CrackTheCode016 CrackTheCode016 deleted the rework-coretime-guides branch September 13, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A2 - Please Review Pull request is ready for review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants