Update auction caches by running the update script locally with fix to Kusama auction 63 & 64 #4138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alfarok
added
A2 - Please Review
|
@DrW3RK I think this should be good to go for now. We can monitor the situation and determine how the missing auction gets re-added as more details become available. The automation script will tell us if future auctions continue as expected or if they don't begin and need to be addressed. |
alfarok
changed the title
alfarok
commented
Dec 6, 2022
| const onboardStartBlock = auctionLeasePeriod * KusamaSlotLeasePeriod + KusamaSlotLeaseOffset; | ||
| const onboardEndBlock = onboardStartBlock + DaysToBlocks(KusamaLeasePeriodPerSlot * 6 * 7); | ||
| return [biddingStarts, auctionEndBlock, onboardStartBlock, onboardEndBlock] | ||
| try { |
There was a problem hiding this comment.
The only change here is wrapping all this logic in a try/catch for better error messaging related to auctions have inaccurate starting blocks defined in the cache.
DrW3RK
approved these changes
Dec 7, 2022
This was referenced Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We saw a failure in the automated auction cache updating script this past week. It appears Auction
#63and#64did not start during the regular cadence.Looking at the Governance Dispatch Queue for Kusama it can be determined that auction
#65is scheduled as the cadence and cache would expect. Also checking some block explorers it appears#63@have not started:https://kusama.subscan.io/auction
or
https://parachains.info/auctions/kusama
For now, I removed
#63and#64from the cache to prevent the automation script from failing.It was determined from https://kusama.polkassembly.io/motion/582 in the discussion below that there was an enactment issue due to an upgrade that caused this auction to not be scheduled. It appears they will be re-scheduled at a later time. When this happens we can re-add
#63and#64at their original indices or new sequential indices.The cache stores the index number so we don't rely on a looping count to determine the auction numbers. This means removing
#63and#64doesn't cause#65to become#63, preserving the expecting numbering.The remaining updates in this PR were generated once I fixed the failure points at
#63and#64. A new try/catch statement was also added to help identify this issue in the future.