Revert "Fixup merkle-value" #702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
IMO we should maybe just get rid off this merkle value. This is used no where in the spec and I only see it bringing confusion, than any help in understanding the spec or whatever. |
|
It is referenced here, in the definition of the subvalue of a trie node. |
Noc2
approved these changes
Sep 11, 2023
There was a problem hiding this comment.
@tjjfvi and @bkchr, thanks a lot for the PR and the active discussion/contribution here. If you plan to contribute more, I'm also happy to add you to the spec committee. https://github.com/w3f/polkadot-spec#spec-committee (approve PRs).
|
@Noc2 Thanks; I would definitely be open to joining the committee. (I have been working on implementing the protocol, and do plan to contribute fixes back to the spec when I have time.) |
heversonbr
approved these changes
Sep 15, 2023
skunert
reviewed
Sep 15, 2023
Co-authored-by: Sebastian Kunert <[email protected]>
heversonbr
approved these changes
Sep 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #698
As discussed in the comments of that PR, the behavior described before by the spec was correct – a node is inlined only if
len < 32.