BABE: added reusing last epoch data in case of skipped epochs #685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
andresilva
approved these changes
Aug 8, 2023
There was a problem hiding this comment.
Definition in spec looks good to me. Although the definition in the description of the PR is a bit ambiguous to me, what is meant by epoch data En? The epoch data that was announced at the beginning of En and that was meant to be used in En + 1? If that's the case then I agree.
Also unrelated to the changes here but in section 5.3 in the Danger box, slot calculation is defined as s = Tunix * slot_duration whereas it should be s = Tunix / slot_duration.
|
thanks, i updated the PR description and fixed the typo. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #681.$E_{n+1}$ to $E_{n+k}$ , the epoch data announced in $E_n$ is used for producing blocks at $E_{n+k+1}$ . This detail has been added in the Block Production section
In case BABE fails to produce blocks for epochs