Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PolkaKey #8

Merged
merged 6 commits into from
Mar 28, 2020
Merged

PolkaKey #8

merged 6 commits into from
Mar 28, 2020

Conversation

HiZhaoYun
Copy link
Contributor

@HiZhaoYun HiZhaoYun commented Mar 23, 2020

Grant Application Checklist

  • The application-template.md has been copied, renamed ( "project_name.md") and updated.
  • A BTC address for the payment of the milestones is provided inside the application.
  • The software of the project will be released under the Apache license version 2.0 as specified in the terms and conditions.
  • The total funding amount of the project is below 30k at the time of submission.

@CLAassistant
Copy link

CLAassistant commented Mar 23, 2020

CLA assistant check
All committers have signed the CLA.

@Noc2
Copy link
Collaborator

Noc2 commented Mar 23, 2020

Hi. Thanks for the application. I just added your desktop wallet sakura to our tech stack document, see https://github.com/w3f/General-Grants-Program/blob/master/grants/polkadot_stack.md#iphone-explorer-and-wallets. In general, multiple wallet providers are currently already working on potentially more secure and more user-friendly solutions (e.g. https://www.parity.io/signer/ or https://github.com/w3f/General-Grants-Program/blob/master/grants/accepted_grant_applications.md). However, given the low total costs of your project, maybe it might be useful as a nice Electron tutorial for our ecosystem. Would you be willing to add a Chinese + English tutorial to your application?

@HiZhaoYun
Copy link
Contributor Author

HiZhaoYun commented Mar 23, 2020

Hi. Thanks for adding sakura to the tech stack document, but this is still an work-in-progress project, and I can only do this work in my spare time, so there are no exact milestones for this project.

Would you be willing to add a Chinese + English tutorial to your application?

I'm not entirely sure I understand what you mean. Do you mean adding a Chinese and English tutorial on how to use PolkaKey? or localize PolkaKey, support Chinese and English.

@Noc2
Copy link
Collaborator

Noc2 commented Mar 24, 2020

Hi. Sorry for the late reply. Regarding sakura, it's not an issue that it's still work in progress. The intention behind the document is also to give other people an overview of existing projects so that they could pick it up and leverage it for their own projects. What I meant with the tutorial was to create one for a simple electron app for substrate/polkadot (similar for example to the following https://substrate.dev/docs/en/tutorials/substrate-front-end/). Basically use this project/PolkaKey also to help other developers to get get started with electron plus our tech stack.

@HiZhaoYun
Copy link
Contributor Author

What I meant with the tutorial was to create one for a simple electron app for substrate/polkadot (similar for example to the following https://substrate.dev/docs/en/tutorials/substrate-front-end/). Basically use this project/PolkaKey also to help other developers to get get started with electron plus our tech stack.

Hi, that's a great idea, and I'd love to do it. But I may need another two weeks to add a Chinese + English tutorial, because I'm very busy recently. I updated the milestone. Please let me know if there are questions.

@Noc2
Copy link
Collaborator

Noc2 commented Mar 26, 2020

Hi. Thanks for adding the tutorial. I have one last request, could you specify the milestone section a little bit better. For example add information on how you're going to test the code (e.g. unit tests, which testing framework, etc.), which function are you implementing (e.g. generate a polkadot address via electron), what is the content of the tutorial, where do you plan to publish it, etc.. We will use this milestone section to test your delivery, so it's basically similar to the requirements of regular contracts and therefore should be specified a little bit more detailed.

@HiZhaoYun
Copy link
Contributor Author

HiZhaoYun commented Mar 27, 2020

Hi. Sorry for the late reply. I added more detail on the milestone. If possible, i hope to publish the tutorial on Polkaworld and Substrate Dev Hub. I'll get in touch with Polkaworld to discuss more details.

Copy link
Collaborator

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding more details. The updated proposal looks good to me.

@HiZhaoYun
Copy link
Contributor Author

Thank you so much! @Noc2 @gavofyork @keorn

@Noc2 Noc2 merged commit a38cb58 into w3f:master Mar 28, 2020
Noc2 pushed a commit that referenced this pull request Nov 19, 2020
@alxs
Copy link
Contributor

alxs commented Mar 2, 2021

Hi @HiZhaoYun, any plans on finishing this grant? Otherwise we would just remove milestone 3 from the proposal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants