Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update substrate_client_java.md #1811

Merged
merged 1 commit into from
Jun 21, 2023

Conversation

strategyobjectadmin
Copy link
Contributor

@strategyobjectadmin strategyobjectadmin commented Jun 20, 2023

Project Abstract

We would like to renew our activities and propose the following modifications to the amendment:

  • to update the address of the company
  • to update estimated delivery
  • to swap milestones 4 and 5
  • to update team members

The application is a follow-up to Substrate Client for Java.

Grant level

  • Level 1: Up to $10,000, 2 approvals
  • Level 2: Up to $30,000, 3 approvals
  • Level 3: Unlimited, 5 approvals (for >$100k: Web3 Foundation Council approval)

Application Checklist

  • The application template has been copied and aptly renamed (project_name.md).
  • I have read the application guidelines.
  • Payment details have been provided (bank details via email or BTC, Ethereum (USDC/DAI) or Polkadot/Kusama (USDT) address in the application).
  • The software delivered for this grant will be released under an open-source license specified in the application.
  • The initial PR contains only one commit (squash and force-push if needed).
  • The grant will only be announced once the first milestone has been accepted (see the announcement guidelines).

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@keeganquigley keeganquigley self-assigned this Jun 20, 2023
@keeganquigley keeganquigley added the amendment This PR proposes changes to an existing application. label Jun 20, 2023
Copy link
Contributor

@keeganquigley keeganquigley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @strategyobjectadmin looks good. I will mark it as ready for review and ping the rest of the committee.

@keeganquigley keeganquigley added the ready for review The project is ready to be reviewed by the committee members. label Jun 20, 2023
Copy link
Collaborator

@takahser takahser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@strategyobjectadmin what's the reason you've replaced @Query and @EventHandles with @Storage and @Event in the annotation support section?

@strategyobjectadmin
Copy link
Contributor Author

@strategyobjectadmin what's the reason you've replaced @Query and @EventHandles with @Storage and @Event in the annotation support section?

hi @takahser,
During the implementation we decided to rename these annotations in accordance with Substrate's attributes (#[pallet::storage] and #[pallet::event]), that was done in scope of the first and second milestones.

@Noc2 Noc2 merged commit cc7b906 into w3f:master Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
amendment This PR proposes changes to an existing application. ready for review The project is ready to be reviewed by the committee members.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants