Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ISO-8553 PoC implementation #1809

Merged
merged 1 commit into from
Jun 20, 2023
Merged

Add ISO-8553 PoC implementation #1809

merged 1 commit into from
Jun 20, 2023

Conversation

dastansam
Copy link
Contributor

@dastansam dastansam commented Jun 19, 2023

Project Abstract

This application is in response to the ISO-8583 RFP.

In this project I aim to implement the proof of concept for the ISO-8583 standard in Substrate. The implementation will be based on the extensive research done by Adit Patel in the following repository.

Grant level

  • Level 1: Up to $10,000, 2 approvals
  • Level 2: Up to $30,000, 3 approvals
  • Level 3: Unlimited, 5 approvals (for >$100k: Web3 Foundation Council approval)

Application Checklist

  • The application template has been copied and aptly renamed (project_name.md).
  • I have read the application guidelines.
  • Payment details have been provided (bank details via email or BTC, Ethereum (USDC/DAI) or Polkadot/Kusama (USDT) address in the application).
  • The software delivered for this grant will be released under an open-source license specified in the application.
  • The initial PR contains only one commit (squash and force-push if needed).
  • The grant will only be announced once the first milestone has been accepted (see the announcement guidelines).
  • I prefer the discussion of this application to take place in a private Element/Matrix channel. My username is: @_______:matrix.org (change the homeserver if you use a different one)

@dastansam dastansam force-pushed the master branch 2 times, most recently from cac5786 to 35d0b87 Compare June 19, 2023 23:20
@dastansam dastansam marked this pull request as ready for review June 19, 2023 23:22
@dastansam dastansam changed the title Add ISO-8553 implementation application Add ISO-8553 PoC implementation Jun 19, 2023
@dastansam dastansam force-pushed the master branch 2 times, most recently from 8747e63 to 333e444 Compare June 20, 2023 00:07
Copy link
Collaborator

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the application. In general, it looks really good. But your first milestone currently doesn't contain any Substrate-specific deliveries. Could you try to change this? Also, it would be nice to have some simple mock-ups or initial designs for the web app.

@Noc2 Noc2 added the changes requested The team needs to clarify a few things first. label Jun 20, 2023
@Noc2 Noc2 self-assigned this Jun 20, 2023
Address more feedback
@dastansam
Copy link
Contributor Author

dastansam commented Jun 20, 2023

hey @Noc2,

thanks for the swift feedback.

I addressed your feedback and here is the summary of what changed:

  • Added more details to the first milestone, specifically about how merchant app and PCIDSS Compliant Gateway will interact with the Substrate chain. PCIDSS Compliant Gateway is tightly coupled to offchain workers, in fact, the combination of both forms a centralized oracle mentioned in the research document. The gateway also does some of the expensive, repetitive tasks (by querying on-chain, basically) before the messages reach offchain workers, so that they only focus on validating and dispatching transactions. I will also include some kind of cryptographic authorization to ensure only offchain workers are consuming messages from the message broker. I think this part of the milestone will be the most challenging and time consuming.
  • Added mockups for merchant app. I won't be focusing a lot of my time on UI, but there will be a payment window page that provides both card and crypto payments.
  • Generally added more documentation where it was lacking

@dastansam dastansam requested a review from Noc2 June 20, 2023 08:22
Copy link
Collaborator

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the super quick update here. I'm happy to go ahead with it and will share it with the rest of the team.

@Noc2 Noc2 added ready for review The project is ready to be reviewed by the committee members. and removed changes requested The team needs to clarify a few things first. labels Jun 20, 2023
Copy link
Contributor

@keeganquigley keeganquigley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dastansam for wanting to work on this! I remember when I talked with Adit Patel, he agreed that the biggest problem here was how to implement chargebacks. I can imagine that other features like authorization holds might also be complex. Anyway, cool to see that you've already done some research on it.

Happy to approve; also Adit mentioned that he's willing to help any team who wanted to work on it, so feel free to reach out to him.

@dastansam
Copy link
Contributor Author

Hey @keeganquigley,

thanks for your feedback!

I read Adit's comments and planning to personally reach out to him

@Noc2 Noc2 merged commit 2ae2e38 into w3f:master Jun 20, 2023
@github-actions
Copy link
Contributor

Congratulations and welcome to the Web3 Foundation Grants Program! Please refer to our Milestone Delivery repository for instructions on how to submit milestones and invoices, our FAQ for frequently asked questions and the support section of our README for more ways to find answers to your questions.

Before you start, take a moment to read through our announcement guidelines for all communications related to the grant or make them known to the right person in your organisation. In particular, please don't announce the grant publicly before at least the first milestone of your project has been approved. At that point or shortly before, you can get in touch with us at [email protected] and we'll be happy to collaborate on an announcement about the work you’re doing.

Lastly, please remember to let us know in case you run into any delays or deviate from the deliverables in your application. You can either leave a comment here or directly request to amend your application via PR. We wish you luck with your project! 🚀

@keeganquigley
Copy link
Contributor

Hi @dastansam how is milestone 2 coming along?

@keeganquigley
Copy link
Contributor

pinging @dastansam

@keeganquigley
Copy link
Contributor

Hi @dastansam are you still working on this grant? Would love to hear an update and find out if you've been having any difficulties.

@keeganquigley
Copy link
Contributor

Hi @dastansam please note that if we don't hear back after two weeks we will go ahead and close this grant due to inactivity.

@dastansam
Copy link
Contributor Author

hey @keeganquigley,

I lost access to my email for this account and didn't get the notification. I am still working on the grant and was planning on submitting the delivery soon. Is it possible to open this grant again?

@dastansam
Copy link
Contributor Author

PR for re-opening here: #2184

hey @keeganquigley,

I lost access to my email for this account and didn't get the notification. I am still working on the grant and was planning on submitting the delivery soon. Is it possible to open this grant again?

@Noc2 Noc2 mentioned this pull request Jan 19, 2024
@keeganquigley
Copy link
Contributor

Thanks @dastansam glad you want to continue working on it, that's no problem.

@keeganquigley
Copy link
Contributor

Hi @dastansam how is it coming along are you still planning to submit this delivery soon?

@dastansam
Copy link
Contributor Author

Hi @dastansam how is it coming along are you still planning to submit this delivery soon?

Hey, yes, hopefully by the end of this week. I'm preparing testing guidelines and docs. Thank you for your patience again!

@Polkadot-Forum
Copy link

This pull request has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/polkadot-iso-20022-integration/8483/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review The project is ready to be reviewed by the committee members.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants