-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Centrifuge gsrpc v2 #1281
Centrifuge gsrpc v2 #1281
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the application. In general, this is definitely something that we want to support. However, could you structure the milestones as shown in our template, here: https://github.com/w3f/Grants-Program/blob/master/applications/application-template.md#milestone-1-example--basic-functionality? The default deliverables 0a-0d below are usually mandatory for all milestones. This helps us with the evaluations and is also part of the terms and conditions. Regarding the maintenance part, ideally, we would keep this separate. Also, our legal team said that for now, we should sign regular contracts for this. So could you remove this initially?
Hi @Noc2, thanks for the feedback. I just pushed the changes suggested. Let me know if anything else is needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the update. I’m happy to support it and share it with the rest of the team. I personally think the price is relatively high, but given that you already put so much effort into it and also maintained it in the past without any support from us, I’m happy to support it.
@mikiquantum thank you for your application. As David said, this is definitely something that we want to support. Just for understanding, why did you pick this specific demand as a new grant proposal since seems that you have many other community demands on the GitHub issues from the project? Is this the best demand to work for now? I think is great to have many demands regarding this project since showing us that is being actually used by the community. I also notice that you are working on that demands as far as possible. |
@dsm-w3f This issue, in a different flavor, has been open for a while centrifuge/go-substrate-rpc-client#220 and indirectly would fix most of the other ones open that are mainly about custom type parsing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the explanation @mikiquantum, I'm quite familiar with team's reputation and am happy to support it as well.
Congratulations and welcome to the Web3 Foundation Grants Program! Please refer to our Milestone Delivery repository for instructions on how to submit milestones and invoices, our FAQ for frequently asked questions and the support section of our README for more ways to find answers to your questions. |
Thank you all for the support! |
Hi @mikiquantum how is milestone 2 coming along? |
@keeganquigley We just merged the v2 work . We will open the deliverable asap. |
@keeganquigley We just opened the Milestone 2 Delivery: w3f/Grant-Milestone-Delivery#890 |
Project Abstract
Initially Go-Substrate-RPC (GSRPC for short) was designed under the premise of being a low-level, static and strongly typed library, where all the type resolution happen at compilation time. This approach allowed almost full flexibility to developers to build their own types and events depending on the target chain/s they were connecting to.
On the other hand, since the types are statically defined, this didn’t leave room to, gracefully, deal with parsing errors when a type (defined on the chain runtime) is not defined in the GSRPC client.
More details in the application commit.
Grant level
Application Checklist
project_name.md
).@_______:matrix.org
(change the homeserver if you use a different one)