Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submit xmc-tools m2 #981

Merged
merged 1 commit into from
Aug 25, 2023
Merged

Submit xmc-tools m2 #981

merged 1 commit into from
Aug 25, 2023

Conversation

gmajor-encrypt
Copy link
Contributor

Milestone Delivery Checklist

  • The milestone-delivery-template.md has been copied and updated.
  • The invoice form 📝 has been filled out for this milestone.
  • This pull request is being made by the same account as the accepted application.
  • I have disclosed any and all sources of reused code in the submitted repositories and have done my due diligence to meet its license requirements.
  • In case of acceptance, the payment will be transferred to the BTC/ETH/fiat account provided in the application.
  • The delivery is according to the Guidelines for Milestone Deliverables.

Link to the application pull request: w3f/Grants-Program#1605

@dsm-w3f
Copy link
Contributor

dsm-w3f commented Aug 24, 2023

@gmajor-encrypt thank you for the milestone delivery and thanks @Whisker17 for the external evaluation. Please see also the comments in this evaluation document and provide proper answers and fixes. Let me know when I can continue this evaluation.

@gmajor-encrypt
Copy link
Contributor Author

hi, @dsm-w3f Thanks for your evaluation. This issue has been fixed. Please check again.

@dsm-w3f
Copy link
Contributor

dsm-w3f commented Aug 25, 2023

@gmajor-encrypt thank you for the improvements and fixes. Now the example provided worked well. See details in the evaluation document. The milestone is approved. I'll forward your invoice and the payment should take place within two weeks. Great job!

@dsm-w3f dsm-w3f merged commit 26c23a5 into w3f:master Aug 25, 2023
6 checks passed
@RouvenP
Copy link

RouvenP commented Sep 1, 2023

hi @gmajor-encrypt we just transferred the payment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants