-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parallel finance - milestone2 #294
Conversation
Thanks for the delivery, @yz89. We will look into it as soon as possible. |
You are welcome and hope you have a good weekend. |
Sorry for the late reply here. I took a very quick look at your delivery and did run into an error when I tried to follow your testing guide. Could you take a look at it? sudo make launch docker-compose -f output/docker-compose.yml -f output/docker-compose.override.yml down --remove-orphans > /dev/null 2>&1 || true rm -fr output || true docker volume prune -f Total reclaimed space: 0B docker image pull parallelfinance/polkadot:v0.9.11 v0.9.11: Pulling from parallelfinance/polkadot Digest: sha256:08777017aef3bc7c55b8711b5cbde54e4589adc4463b61d6c86192f70b88566a Status: Image is up to date for parallelfinance/polkadot:v0.9.11 docker.io/parallelfinance/polkadot:v0.9.11 docker image pull parallelfinance/parallel:latest latest: Pulling from parallelfinance/parallel Digest: sha256:63a2f4e41f4d3cee86255b7cedbdba37a3d1430a0edde2756cf1728016f83fa2 Status: Image is up to date for parallelfinance/parallel:latest docker.io/parallelfinance/parallel:latest docker image pull parallelfinance/stake-client:latest latest: Pulling from parallelfinance/stake-client Digest: sha256:c771aa8a139ad6a5865714bcf82691e904d4acf9ef7ecf0f5124f3581664f74c Status: Image is up to date for parallelfinance/stake-client:latest docker.io/parallelfinance/stake-client:latest docker image pull parallelfinance/liquidation-client:latest latest: Pulling from parallelfinance/liquidation-client Digest: sha256:4813181e25af3d51b9ec82dc3389537e44fc6827380508138de4dae4b365156f Status: Image is up to date for parallelfinance/liquidation-client:latest docker.io/parallelfinance/liquidation-client:latest docker image pull parallelfinance/nominate-client:latest latest: Pulling from parallelfinance/nominate-client Digest: sha256:0807154f67aca8f389297fc49bf6b69318567194c3bac6487ba2d10723beec74 Status: Image is up to date for parallelfinance/nominate-client:latest docker.io/parallelfinance/nominate-client:latest docker image pull parallelfinance/oracle-client:latest latest: Pulling from parallelfinance/oracle-client Digest: sha256:1610b5c9c8b1fc4e7eed1c754a65040afcc2c9f522a87de8220f3ad27d62bb27 Status: Image is up to date for parallelfinance/oracle-client:latest docker.io/parallelfinance/oracle-client:latest docker image pull parallelfinance/parallel-dapp:latest latest: Pulling from parallelfinance/parallel-dapp Digest: sha256:69b393618b4a348456949a66fe425b9b0ef7b2ecbc91ec8eca2d978be14863fc Status: Image is up to date for parallelfinance/parallel-dapp:latest docker.io/parallelfinance/parallel-dapp:latest parachain-launch generate config.yml && (cp -r keystore* output || true) && cp docker-compose.override.yml output && cd output && docker-compose up -d --build /bin/sh: 1: parachain-launch: not found make: *** [Makefile:95: launch] Error 127 Should I test a specific commit/version? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also the UI currently doesn’t let me select polkadot. Not sure if this is on purpose.
Sorry for forgetting mention the parachain-launch tool. I updated the Test Guide. You need to install the parachain-launch: |
Yes, polkadot is not available yet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’m happy to tell you that the milestone is a pass. I will forward your invoice internally. You can find my evaluation here.
Great. Thanks for your work. |
Milestone Delivery Checklist
Link to the application pull request: w3f/Grants-Program#329