Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subxtpy Milestone 2 #1213

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Subxtpy Milestone 2 #1213

merged 2 commits into from
Oct 14, 2024

Conversation

philoniare
Copy link
Contributor

Milestone Delivery Checklist

  • The milestone-delivery-template.md has been copied and updated.
  • This pull request is being made by the same account as the accepted application.
  • I have disclosed any and all sources of reused code in the submitted repositories and have done my due diligence to meet its license requirements.
  • In case of acceptance, invoices must be submitted and payments will be transferred to the Polkadot AssetHub and/or fiat account provided in the application.
  • The delivery is according to the Guidelines for Milestone Deliverables.

Link to the application pull request: Proposal.

@PieWol PieWol self-assigned this Oct 10, 2024
@PieWol
Copy link
Member

PieWol commented Oct 10, 2024

Hey @philoniare , thanks for your delivery. We will look into it and get back to you in case of any questions :)

@PieWol
Copy link
Member

PieWol commented Oct 10, 2024

Hey @philoniare ,
for deliverable 1 and 2 you listed the same link. I assume one is wrong. Would you mind to fix that?

@philoniare
Copy link
Contributor Author

philoniare commented Oct 10, 2024

@PieWol Yep, updated, right now, the user can subscribe to new blocks (they can fetch block details and all of the extrinsics associated with the new block) and events as they come in real-time.

@PieWol
Copy link
Member

PieWol commented Oct 10, 2024

Thanks, sadly I get this error when running the tests. Do you have any idea why? I'm running the node locally with the flags you provided and on port 9944. I have no clue what went wrong.

_______________________________________________________________________ test_subscribe_new_blocks _______________________________________________________________________

    @pytest.mark.asyncio
    async def test_subscribe_new_blocks():
        client = await SubxtClient.new()
>       subscription = await client.subscribe_new_blocks()
E       AttributeError: 'builtins.SubxtClient' object has no attribute 'subscribe_new_blocks'

tests/test_subscription.py:8: AttributeError
======================================================================== short test summary info ========================================================================
FAILED tests/test_subscription.py::test_subscribe_new_blocks - AttributeError: 'builtins.SubxtClient' object has no attribute 'subscribe_new_blocks'
====================================================================== 1 failed, 7 passed in 0.29s ==============

@philoniare
Copy link
Contributor Author

@PieWol I believe a previous version got installed, could you please make sure that the version is 0.2.0 by running this?

pip install subxtpy==0.2.0

Thanks, lmk if it still doesn't work.

@PieWol
Copy link
Member

PieWol commented Oct 10, 2024

@PieWol I believe a previous version got installed, could you please make sure that the version is 0.2.0 by running this?

pip install subxtpy==0.2.0

Thanks, lmk if it still doesn't work.

Great, that fixed it! What do you need to change in the readme or the requirements so that it works straight up? :)

@philoniare
Copy link
Contributor Author

@PieWol thanks for pointing it out, I've updated the README with the upgrade option so that it fetches the latest version.

@PieWol
Copy link
Member

PieWol commented Oct 10, 2024

Hey @philoniare ,
sounds good. I put up a PR with my evaluation which still contains a few little comments. e.g. about the Sphinx documentation and another package which seems to be needed but isn't mentioned in the readme. Looking forward to you addressing these minor comments. Should be resolved quickly 👍 .
https://github.com/w3f/Grant-Milestone-Delivery/pull/1214/files

@philoniare
Copy link
Contributor Author

philoniare commented Oct 10, 2024

@PieWol thanks for the review, I'll be resolving those issues soon. I haven't tried installing it on ubuntu, will be sure to test out the flow and update the docs for linux.

@philoniare
Copy link
Contributor Author

@PieWol updated the readme with linux instructions and fixed the issue with styling for sphinx: docs

@PieWol
Copy link
Member

PieWol commented Oct 13, 2024

Hey @philoniare ,
thanks for the latest changes. I still think the documentation needs a little love. Could you introduce spaces between the different classes so that it isn't a huge wall of text?

Why is the actual header and search bar of the documentation at the bottom?

@philoniare
Copy link
Contributor Author

Hey @PieWol, I totally agree with you. The existing sphinx doc site wasn't doing the project justice, so I've chosen to document it with custom markdown files using mkdocs. The new doc site is available here.

Thanks

@PieWol
Copy link
Member

PieWol commented Oct 14, 2024

Awesome changes 👍 Documentation looks nice now.

@PieWol PieWol merged commit 5a434d6 into w3f:master Oct 14, 2024
3 checks passed
Copy link

🪙 Please fill out the invoice form in order to initiate the payment process. Thank you!

Copy link

We noticed that this is the last milestone of your project. Congratulations on completing your grant! 🎊

So, where to from here? First of all, you should join our Grants Community chat, if you haven't already, so we can stay in touch.
If you are looking for continuative support for your project, there are quite a few options. The main goal of the W3F grants program is to support research as well as early-stage technical projects. If your project still falls under one of those categories, you might want to apply for a follow-up grant. However, depending on your goals and project status, there are other support programs in our ecosystem that might be better suited as the next step. For example, projects with a Business Case/Token should look into the Substrate Builders Program or VC Funding and Common Good projects have a good chance of receiving Treasury Funding. If you are looking for guidance, the team at https://substrate.io/ecosystem/square-one/ has compiled a list of ecosystem support sources and are happy to help you navigate it.

For a more comprehensive list, see our Alternative Funding page. Let us know if you have any questions regarding the above. We are more than happy to point you to additional resources and help you determine the best course of action.
Lastly, we hope your W3F grant was a success and we want to thank you for being part of the journey!

@PieWol
Copy link
Member

PieWol commented Oct 14, 2024

Congrats on successfully delivering your grant 🎉 !

I hope this keeps getting maintained and used :)

@philoniare
Copy link
Contributor Author

Thanks for the detailed review as always!

For sure! Will be sure to keep a close eye on dev demand and feature requests.

@RouvenP
Copy link

RouvenP commented Oct 25, 2024

hi @philoniare we sent the payments today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants