Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add section on new features being detectable. #82

Merged
merged 2 commits into from
Oct 17, 2017

Conversation

dbaron
Copy link
Member

@dbaron dbaron commented Oct 13, 2017

This was originally part of #75, but it seemed worth splitting out both
into a separate section and a separate pull request.

This was originally part of w3ctag#75, but it seemed worth splitting out both
into a separate section and a separate pull request.
dbaron added a commit to dbaron/design-principles that referenced this pull request Oct 14, 2017
Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % nit.

index.bs Outdated
and to features that may not be present in a particular configuration
(ranging from features that are present only if particular hardware is present,
to features that are
only available in secure contexts.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lacks closing ).

Copy link

@mikewest mikewest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nits in addition to Anne's. Otherwise LGTM!

index.bs Outdated
<h3 id="feature-detect">New features should be detectable</h3>

The existence of new features should generally be detectable,
so that web content can act appropriately if the feature is present or not.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style nit: I'd suggest replacing "if" with "whether".

index.bs Outdated
This applies both to features that
are not present because they are not implemented,
and to features that may not be present in a particular configuration
(ranging from features that are present only if particular hardware is present,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps "present only on particular platforms"? It would be strange if, for instance, the WebUSB API disappeared entirely when no USB devices were plugged in.

@dbaron dbaron merged commit 842b12e into w3ctag:master Oct 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants