[W3C-93] New race win icons #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
godrien
approved these changes
Jul 7, 2022
| new AvatarCategoryToMaxPictureId(AvatarCategory.NE, GetMaxPictureIdForRace(Race.NE)), | ||
| new AvatarCategoryToMaxPictureId(AvatarCategory.UD, GetMaxPictureIdForRace(Race.UD)), | ||
| new AvatarCategoryToMaxPictureId(AvatarCategory.RnD, GetMaxPictureIdForRace(Race.RnD)), | ||
| new AvatarCategoryToMaxPictureId(AvatarCategory.Total, GetMaxPictureIdForAllWins()), |
There was a problem hiding this comment.
The AvatarCategory.Tournament won't be available for now, right?
There was a problem hiding this comment.
correct, wont be used for now.
| Race = AvatarCategory.Total, | ||
| PictureId = 0 | ||
| Race = AvatarCategory.Starter, | ||
| PictureId = random.Next(1,5), |
There was a problem hiding this comment.
This will not generate the id 5, but there are 5 starter icons in the definition of the PR description. So the 5th would never be the default @Cepheid-UK
There was a problem hiding this comment.
I am also renaming the icon portraits to start at 1, instead of 0 as before. Which I realise may cause issues elsewhere, but that will have to be fixed too 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket:
W3C-93 - New Race Wins Icons
Description:
AvatarCategorynotRaceStarterandTournamenttoAvatarCategoryEnumsPickablePictures