-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is PublicationLink a misnomer? #356
Comments
We started using However, the latest proposals around audio and video books brought to the fore that, in fact, we are not characterizing a link; we are in fact characterizing the resource at the "end" of the link. Hence my feeling that referring to a link is a misnomer. Consider the term There are two properties that may have to change if we look at that structure and consider it as a description of the resource:
Looking at one of the examples for media sync it becomes way cleaner. If we say: "readingOrder": [
"...",
{
"type": "PublicationResource",
"id": "chapter1.html",
"encodingFormat": "text/html",
"sync-media": {
"type": "PublicationResource",
"id": "sync-media/chapter1.json",
"encodingFormat": "application/vnd.wp-sync-media+json",
"duration": 123.45
}
},
"..."
] What this says is: "we have an html resource identified by 'chapter1.hml' which is overlayed by another resource, which happens to be of the 'vnd.wp-sync-media+json' format, has a duration of 123.45 as identified by 'sync-media/chapter1.json'." Just try to describe the same structure if talking about links... |
PublicationLink
a misnomer?
@iherman your semantic web experience "talks" there. I agree that if RDF-speak we have here a resource with properties. |
Overall I agree but I have two comments regarding that proposal:
|
I am fine with changing to |
This shows that the term |
If I had a freedom I would say the term should be
That is a separate issue, regardless of the term we use. Let us move that into a separate issue if we want to address it. |
Yes, this bother me, as well. It'll be confusing to say that the reading order and resource list are the definitive source of publication resources while we use something called PublicationResource to describe links. Can't we just call it LinkedResource and avoid the implications of whether it belongs to the publication or not? |
I like |
Why not |
|
Also, we're not using |
(In ugly RDF terms the current structure creates blank node for the whole structure, whereas using |
Is this what we are expressing? When I say I like |
That's how rel is generally understood, yes. How is that document related to this one. I wouldn't suggest we mint something new unless there's a good case why it doesn't apply. I personally have always disliked "contents" as the identifier for the table of contents, though. I know it's the typical title for the table of contents within a work, and there's some unadopted precedent for it in HTML, but it's also ambiguous with the content or contents of the publication itself. (But I'm not expecting to win that argument here.) |
O.k. If everybody is fine with keeping (The issue whether 'contents' is a good name for what we use it for is a separate issue, let us not discuss it here.) |
To explain a bit what I said in #356 (comment) (sorry about "id":"http://mybook",
"resources" : {
"type": "LinkedResource",
"url": "http://ex.org",
"duration":1234
} Translates into:
whereas if I replace
One could argue that the second set of statements more naturally translates our model into syntax. But it may be a difference in modeling style. |
(Trying to get this issue solved) I think where we are at this point is:
|
In fact... (I swear I do not do this to get a closure no matter what:-) we may want to keep both "resources": {
"url" : "https://www.w3.org/TR/2018/WD-wpub-20180814/",
"id" : "https://www.w3.org/TR/wpub/",
...
} using |
@iherman I understand your comment from an RDF perspective, but IMO it doesn't necessarily matter that much in our case since we're mostly targeting schema.org processors rather than generic RDF ones. One could also argue that while you always know the |
I am not sure what schema.org does, actually. I could imagine the do handle But, I believe, my comment in #356 (comment) holds. At the moment |
@iherman from an author or a UA perspective, I really don't see any benefit to that approach, it just makes things more confusing. The only benefit is the RDF output as I've stated in my previous comment. |
This is already the case, isn't it? We have |
Actually, any object in Schema.org has this dual feature. Us restricting may be seen as a mistake... |
@iherman this is turning into a completely different discussion, can we close this one and open a separate issue? I would be perfectly fine restricting our spec to:
Given our extensibility model (JSON-LD + schema.org), we would not restrict the use of whatever's allowed in schema.org for such models, but we wouldn't give false expectations regarding the behavior of the UA either. |
+1 to Hadrien, intellectual purity in such a case goes easily against interoperability: a UA will not process the id on linked resources (resp. an url of person/company), even if an author believes so because the spec allows for it. |
I would definitely be opposed to make a restriction to Person/Company. There are cases when the I will not lie down the road on this, although I do feel uncomfortable with using exclusively That issue being put aside, are we fine with #356 (comment)? I am happy to do a PR around it (unless @mattgarrish prefers to wait until we resolve and merge #359 to avoid merge hell). |
Yes, very much... :) |
@iherman what's the use case for For |
If you have time, you can dive into https://en.wikipedia.org/wiki/HTTPRange-14 :-) I am not saying we should decide on this, certainly not. If we explicitly disallow the usage of Yes, this may be a purist's standpoint. But we should not put ourselves into the crosshair of this. |
Once again, disallowing is not something that anyone has suggested but there's a difference between putting the spotlight on it in our spec and keeping things possible as part of our extensibility model. |
@HadrienGardeur you are right this is a separate issue. If you want to raise it separately, go ahead; we are not discussing at this moment to go back to some of the definitions that have been around in the manifest for a while. (I am partially to blame for making reference to it.) |
Using the right terminology is important, because it also suggests some sort of a "mental model" of what we are doing. In this sense, I would suggest that the term "PublicationLink" is not the right term, mainly with the additional features proposed (for good reasons!) for audio or video books. I would suggest we would use the term
PublicationResource
(we can bike shed on a better term) and some of the constituent terms may also have to be changed.If we agree, we should also close #235 ("Using LinkRole instead of PublicationLink") as being overtaken by events.
@BigBlueHat @HadrienGardeur @laudrain @TzviyaSiegman @wareid @llemeurfr
The text was updated successfully, but these errors were encountered: