Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-work Privacy & Security Considerations #248

Closed
benfrancis opened this issue Jul 20, 2022 · 3 comments
Closed

Re-work Privacy & Security Considerations #248

benfrancis opened this issue Jul 20, 2022 · 3 comments
Assignees

Comments

@benfrancis
Copy link
Member

I propose:

  • Moving Privacy Considerations and Security Considerations sections to the top level of the document, at the end, as is normal for W3C specifications
  • Removing section 7.2.8.4 Transport security since all of the feedback on the PR seemed to be not to include it
  • Instead add some text to Security Considerations to recommend following best practices from the WoT Security Best Practices document, as suggested by @mmccool

I can provide a PR.

Note: From GitHub it appears that #87 and #206 were merged without review. I assume there is a good reason for that, but if a decision is made during a meeting to merge a PR, it would be great if whoever merges it leaves a note to that effect before merging, so we don't have to trawl through meeting notes to figure out if a pull request was merged in error. It looks really odd when all the review comments say not to merge something and then it's merged anyway, so it would be good to explain why the decision contradicted the feedback provided.

@benfrancis
Copy link
Member Author

Note that a reference was added to the security best practices document in #124, but it should probably be moved to the new security considerations section as part of this issue.

@mlagally
Copy link
Contributor

mlagally commented Aug 1, 2022

@benfrancis

Note: From GitHub it appears that #87 and #206 were merged without review. I assume there is a good reason for that, but if a decision is made during a meeting to merge a PR, it would be great if whoever merges it leaves a note to that effect before merging, so we don't have to trawl through meeting notes to figure out if a pull request was merged in error. It looks really odd when all the review comments say not to merge something and then it's merged anyway, so it would be good to explain why the decision contradicted the feedback provided.

Can you please elaborate your comment? I may have misunderstood, but I don't see any comments in #87 or #206 that raise any concern with the proposed text. What is your specific concern here?
We are reviewing all PRs in our weekly calls among all participants, so it is very unlikely that something is merged by "error".

@benfrancis
Copy link
Member Author

What is your specific concern here?

To be clear I am not suggesting any wrong doing, just suggesting better record keeping to avoid misunderstandings.

For #87:

  • The consensus of the discussion appears to be that we can not mandate TLS, and should instead defer to the Security Best Practices document which already recommends it. This would mean no need for a Transport Security section, just some brief text in the Security Considerations section, which should be at the top level of the document. I've suggested a fix for that in this issue.
  • There are no code review approvals or written record of the decision to merge the PR.

For #206:

benfrancis added a commit to benfrancis/wot-profile that referenced this issue Aug 10, 2022
benfrancis added a commit to benfrancis/wot-profile that referenced this issue Aug 10, 2022
benfrancis added a commit to benfrancis/wot-profile that referenced this issue Aug 24, 2022
benfrancis added a commit to benfrancis/wot-profile that referenced this issue Aug 24, 2022
benfrancis added a commit to benfrancis/wot-profile that referenced this issue Aug 31, 2022
benfrancis added a commit to benfrancis/wot-profile that referenced this issue Aug 31, 2022
benfrancis added a commit to benfrancis/wot-profile that referenced this issue Aug 31, 2022
mlagally added a commit that referenced this issue Aug 31, 2022
Re-structure profiles sections - closes #214 and closes #248
mlagally added a commit that referenced this issue Aug 31, 2022
Remove cloud events as message format for WebHooks, update README.md (#248)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants