-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-work Privacy & Security Considerations #248
Comments
Note that a reference was added to the security best practices document in #124, but it should probably be moved to the new security considerations section as part of this issue. |
Can you please elaborate your comment? I may have misunderstood, but I don't see any comments in #87 or #206 that raise any concern with the proposed text. What is your specific concern here? |
To be clear I am not suggesting any wrong doing, just suggesting better record keeping to avoid misunderstandings. For #87:
For #206:
|
Remove cloud events as message format for WebHooks, update README.md (#248)
I propose:
I can provide a PR.
Note: From GitHub it appears that #87 and #206 were merged without review. I assume there is a good reason for that, but if a decision is made during a meeting to merge a PR, it would be great if whoever merges it leaves a note to that effect before merging, so we don't have to trawl through meeting notes to figure out if a pull request was merged in error. It looks really odd when all the review comments say not to merge something and then it's merged anyway, so it would be good to explain why the decision contradicted the feedback provided.
The text was updated successfully, but these errors were encountered: