-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add alternative payload format (2) #213
Conversation
Thanks. I think the content is fine, but it needs some more work:
Some editorial issues:
|
Thanks for the feedback @farshidtz ! I applied your comments and will need some help with:
Let's resolve it in today's meeting. |
index.html
Outdated
in <a href="https://www.hydra-cg.com/spec/latest/core/#advanced-concepts"> | ||
Hydra Advanced Concepts</a>. More concretely the | ||
<a href="https://www.hydra-cg.com/spec/latest/core/#example-20-a-hydra-partialcollectionview-splits-a-collection-into-multiple-views"> | ||
Partial Collection View</a> using the <i>members</i> field to accomodate the array |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"members" -> "member" ?
Needs some refinement. In particular, as discussed, it's troublesome to depend normatively on a CG document, and it's also a problem to just define an extension point (with hydra collections as examples) since that creates interop problems. We need a built-in normative way to do this, but can't just adopt the hydra ontology directly. So it was suggested that we resurrect the design we had discussed in #16 and which can be seen in the context history, see e.g. de02ff0#diff-94098f295e6c8f89beca5d1221bbaefaf5c410e17b1a6be3d5df9051b205f72f |
Since we are not strictly following hydra anymore, why don't we use plural
to
The following maps better: or simply: |
Thanks for the comment! |
context/discovery-context.jsonld
Outdated
}, | ||
"total": "discovery:contains", | ||
"members": [ | ||
"@graph" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This perhaps should be td:Thing included from the td context, since in the intent is to return TDs (formatted as TDs) and not general RDF graphs.
I have to review in detail the new context, but maybe it would be better to have a separate context with the pagination terms, and the range of the term members should point to td:Thing or any of the types defined in the discovery context. In this way this second context is totally optional and would point to the main one |
Rework of #168
resolves #16
Preview | Diff