Allow external language information to apply #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 13, 2015
zcorpan
added a commit
to whatwg/html
that referenced
this pull request
Nov 13, 2015
The `<track srclang>` value (as well as in-band track language info) should be forwarded to the track format's rendering rules. For WebVTT, see w3c/webvtt#257 and https://www.w3.org/Bugs/Public/show_bug.cgi?id=28255.
|
Should the "List of WebVTT Node Objects" object have a "lang" attribute for the purpose of Selectors? (Similar to https://w3c.github.io/webvtt/#selectordef-cue-selector
|
|
LGTM. To hand down the |
Make it possible for `<track srclang>` (or other external language) to apply to the WebVTT nodes for the purpose of CSS `:lang()` matching, glyph selection, etc. "WebVTT cue text parsing rules" takes an optional fallback language. The "rules for updating the display of WebVTT text tracks" also takes an optional fallback language, since it is the entry point for HTML and this algorithm then invokes the "WebVTT cue text parsing rules". `getCueAsHTML()` does not provide a fallback language. Fixes (1) in https://www.w3.org/Bugs/Public/show_bug.cgi?id=28255#c16.
zcorpan
force-pushed
the
apply-external-lang
branch
from
8411423 to
a853eee
Compare
zcorpan
added a commit
that referenced
this pull request
Nov 16, 2015
zcorpan
added a commit
to whatwg/html
that referenced
this pull request
Nov 16, 2015
The `<track srclang>` value (as well as in-band track language info) should be forwarded to the track format's rendering rules. For WebVTT, see w3c/webvtt#257 and https://www.w3.org/Bugs/Public/show_bug.cgi?id=28255.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it possible for
<track srclang>(or other external language)to apply to the WebVTT nodes for the purpose of CSS
:lang()matching,glyph selection, etc.
"WebVTT cue text parsing rules" takes an optional fallback language.
The "rules for updating the display of WebVTT text tracks" also takes
an optional fallback language, since it is the entry point for HTML
and this algorithm then invokes the "WebVTT cue text parsing rules".
getCueAsHTML()does not provide a fallback language.Fixes (1) in https://www.w3.org/Bugs/Public/show_bug.cgi?id=28255#c16.