-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add per-stream getStats(). #395
Conversation
@ylafon @dontcallmedom any idea why these checks are failing?
|
index.bs
Outdated
DOMHighResTimeStamp timestamp; | ||
unsigned long long amountWrittenTo; | ||
unsigned long long sentProgress; | ||
unsigned long long acknowledgedProgress; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bytesAcknowledged ?
Meeting:
|
The actual error is hidden above that bogus error message:
|
Subclassing looks okay to me. The IDL for |
@martinthomson does this LGTY to merge, or should we keep bikeshedding? |
With the benfit of some hindsight, I'm questioning whether our concerns over understandability justify the awkward naming: dictionary WebTransportSendStreamStats {
DOMHighResTimeStamp timestamp;
unsigned long long amountWrittenTo;
unsigned long long sentProgress;
unsigned long long acknowledgedProgress;
};
dictionary WebTransportReceiveStreamStats {
DOMHighResTimeStamp timestamp;
unsigned long long receivedProgress;
unsigned long long amountReadFrom;
}; The following does seem simpler: dictionary WebTransportSendStreamStats {
DOMHighResTimeStamp timestamp;
unsigned long long bytesWritten;
unsigned long long bytesSent;
unsigned long long bytesAcknowledged;
};
dictionary WebTransportReceiveStreamStats {
DOMHighResTimeStamp timestamp;
unsigned long long bytesReceived;
unsigned long long bytesRead;
}; |
Meeting:
|
Fixes #372.
Preview | Diff