Prioritize outgoing datagrams over stream data #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PTAL. If this looks good I'll change the milestone of #62. |
Discussed at #62. Explicitly state that outgoing datagrams are prioritized for now. We will introduce a way to change this default behavior, as part of the prioritization API.
yutakahirano
force-pushed
the
yhirano/datagram-stream-priority
branch
from
502446f
to
4122fe6
Compare
jan-ivar
approved these changes
Aug 31, 2021
|
@vasilvv can you take a look? Is this aligned with what we're doing in Chrome? |
|
The actual logic of what we're doing is actually really complicated (since it has to account for retransmissions, control frames, etc), but as an approximation, this is correct. |
vasilvv
approved these changes
Aug 31, 2021
|
Thank you! |
github-actions bot
added a commit
that referenced
this pull request
Sep 1, 2021
SHA: 5bf0bba Reason: push, by @yutakahirano Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussed at #62. Explicitly state that outgoing datagrams are
prioritized for now. We will introduce a way to change this
default behavior, as part of the prioritization API.
Preview | Diff