Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add datagrams.setSendQueueExpiration(long duration)? #251

Closed
jan-ivar opened this issue Apr 27, 2021 · 4 comments · Fixed by #267
Closed

Add datagrams.setSendQueueExpiration(long duration)? #251

jan-ivar opened this issue Apr 27, 2021 · 4 comments · Fixed by #267
Assignees
@yutakahirano
Labels
Ready for PR
Milestone
Minimum viable ship

Comments

@jan-ivar
Copy link
Member

No description provided.

@jan-ivar jan-ivar assigned jan-ivar and yutakahirano and unassigned jan-ivar Apr 27, 2021
@yutakahirano
Copy link
Contributor

I have some naming preferences. What do people think?

  • Is it better to keep the suffix "Duration"?
  • I slightly prefer "Outgoing" to "SendQueue" (With "Outgoing" I think we don't need "Queue").
  • I can make them attributes.

@yutakahirano yutakahirano mentioned this issue May 18, 2021
Merged
@yutakahirano
Copy link
Contributor

A PR is available at #267.

@ricea
Copy link
Contributor

ricea commented May 19, 2021

How about setOutgoingMaxAge()?

@yutakahirano
Copy link
Contributor

setOutgoingMaxAge/setIncomingMaxAge SGTM.

@wilaw wilaw added this to the Minimum viable ship milestone May 26, 2021
yutakahirano added a commit that referenced this issue Jun 16, 2021
@yutakahirano
Define datagram backpressure control attributes (#267)
809721b 
- incomingMaxAge
- outgoingMaxAge
- incomingHighWaterMark
- outgoingHighWaterMark

Fixes #251, #221, #152
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yutakahirano yutakahirano

Labels
Ready for PR
Projects
None yet
Milestone
Minimum viable ship
Development

Successfully merging a pull request may close this issue.

Define datagram backpressure control attributes w3c/webtransport
4 participants
@wilaw @jan-ivar @yutakahirano @ricea