Add back RTCInsertableStreams which was removed by error in PR62 #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #72 |
|
Thanks @youennf! |
|
@dontcallmedom, 'make' did not catch this missing reference. |
dontcallmedom
added a commit
that referenced
this pull request
Mar 8, 2021
Using spec-prod configuration to detect when the spec uses undefined references https://github.com/w3c/spec-prod/blob/main/docs/options.md#build_fail_on Per #73 (comment)
|
#74 will configure the bot to detect that kind of error, although the bot itself has bug at the moment; SFrameTransportOptions seems to be also missing (and thus will make the build fail once the bot is correctly set up) |
Thanks! |
jan-ivar
approved these changes
Mar 11, 2021
dontcallmedom
added a commit
that referenced
this pull request
Mar 11, 2021
Using spec-prod configuration to detect when the spec uses undefined references https://github.com/w3c/spec-prod/blob/main/docs/options.md#build_fail_on Per #73 (comment)
dontcallmedom
added a commit
that referenced
this pull request
Mar 11, 2021
Using spec-prod configuration to detect when the spec uses undefined references https://github.com/w3c/spec-prod/blob/main/docs/options.md#build_fail_on Per #73 (comment)
youennf
pushed a commit
that referenced
this pull request
Mar 11, 2021
* Detect missing references on build Using spec-prod configuration to detect when the spec uses undefined references https://github.com/w3c/spec-prod/blob/main/docs/options.md#build_fail_on Per #73 (comment) * Disambiguate autolink on resolve
github-actions bot
added a commit
that referenced
this pull request
Mar 11, 2021
…ing references on buildUsing spec-prod configuration to detect when the spec uses undefined references https://github.com/w3c/spec-prod/blob/main/docs/options.md#build_fail_onPer #73 (comment) Disambiguate autolink on resolve SHA: 0f203e1 Reason: push, by @youennf Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
saschanaz
added a commit
to saschanaz/webref
that referenced
this pull request
Mar 12, 2021
tidoust
pushed a commit
to w3c/webref
that referenced
this pull request
Apr 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview | Diff