feat: support [Exposed=*]
#634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saschanaz
commented
Nov 2, 2021
| { | ||
| "type": "interface", | ||
| "name": "X", | ||
| "inheritance": null, |
There was a problem hiding this comment.
Hmm? Is null deprecated in JSON?
There was a problem hiding this comment.
Is
nulldeprecated in JSON?
Almost certainly not, because as far as I understand it, JSON syntax is forever set in stone, which unfortunately means that comments will almost certainly never be supported, even though they existed in the initial drafts.
There was a problem hiding this comment.
Yes, that's my understanding. Not sure why the red highlight 🤔. Also not sure where to report.
There was a problem hiding this comment.
Looks like it just got fixed in Nixinova/NovaGrammars#7, which is the project @github uses for highlighting JSON syntax: https://github.com/github/linguist/tree/master/vendor.
marcoscaceres
approved these changes
Nov 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corresponds to whatwg/webidl#526
This patch closes #__ and includes: