-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add permissions.requestSiteAccess() API proposal #529
Merged
Merged
Commits on Jan 24, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 0337140 - Browse repository at this point
Copy the full SHA 0337140View commit details
Commits on Jan 31, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ce54af5 - Browse repository at this point
Copy the full SHA ce54af5View commit details
Commits on Feb 7, 2024
-
Update proposal based on comment threads
- Update Background section to take into account different browser's behavior - Update Other Alternatives Considered section to explain in better detailed why Chrome is not supportive of declarative urls
Configuration menu - View commit details
-
Copy full SHA for 3a11106 - Browse repository at this point
Copy the full SHA 3a11106View commit details
Commits on Feb 28, 2024
-
Add url option parameter and return value
Proposal has been updated so it can fit every browsers model by adding a url option parameter, with this requirements: - In Chrome, we can require tab ID or document ID, but not `url`. - In Safari, they can require `url`, but not `tabId` or `documentId`. - If both are provided, they'll both be respected. It also adds a method to remove the request and specifies when the methods resolve
Configuration menu - View commit details
-
Copy full SHA for c1d2c83 - Browse repository at this point
Copy the full SHA c1d2c83View commit details
Commits on Feb 29, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f3ec64f - Browse repository at this point
Copy the full SHA f3ec64fView commit details
Commits on Mar 4, 2024
-
Address comments after 02/29 WECG meeting
- Change name to `permissions.addSiteAccessRequest()` - Fix API comments
Configuration menu - View commit details
-
Copy full SHA for 97adc54 - Browse repository at this point
Copy the full SHA 97adc54View commit details
Commits on Mar 11, 2024
-
Configuration menu - View commit details
-
Copy full SHA for db2642b - Browse repository at this point
Copy the full SHA db2642bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 42e10b0 - Browse repository at this point
Copy the full SHA 42e10b0View commit details
Commits on Mar 20, 2024
-
Apply suggestions from code review
Co-authored-by: Rob Wu <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for e8431e9 - Browse repository at this point
Copy the full SHA e8431e9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5267c8c - Browse repository at this point
Copy the full SHA 5267c8cView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.