Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add permissions.requestSiteAccess() API proposal #529

Merged
merged 10 commits into from
Mar 21, 2024

Commits on Jan 24, 2024

  1. Configuration menu
    Copy the full SHA
    0337140 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2024

  1. Configuration menu
    Copy the full SHA
    ce54af5 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2024

  1. Update proposal based on comment threads

    - Update Background section to take into account different browser's behavior
    - Update Other Alternatives Considered section to explain in better detailed why Chrome is not supportive of declarative urls
    EmiliaPaz authored Feb 7, 2024
    Configuration menu
    Copy the full SHA
    3a11106 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2024

  1. Add url option parameter and return value

    Proposal has been updated so it can fit every browsers model by adding a url option parameter, with this requirements:
    - In Chrome, we can require tab ID or document ID, but not `url`.
    - In Safari, they can require `url`, but not `tabId` or `documentId`.
    - If both are provided, they'll both be respected.
    
    It also adds a method to remove the request and specifies when the methods resolve
    EmiliaPaz authored Feb 28, 2024
    Configuration menu
    Copy the full SHA
    c1d2c83 View commit details
    Browse the repository at this point in the history

Commits on Feb 29, 2024

  1. Change title

    EmiliaPaz authored Feb 29, 2024
    Configuration menu
    Copy the full SHA
    f3ec64f View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2024

  1. Address comments after 02/29 WECG meeting

    - Change name to `permissions.addSiteAccessRequest()`
    - Fix API comments
    EmiliaPaz authored Mar 4, 2024
    Configuration menu
    Copy the full SHA
    97adc54 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2024

  1. Small typos in proposal

    EmiliaPaz authored Mar 11, 2024
    Configuration menu
    Copy the full SHA
    db2642b View commit details
    Browse the repository at this point in the history
  2. Add inactive tab behavior

    EmiliaPaz authored Mar 11, 2024
    Configuration menu
    Copy the full SHA
    42e10b0 View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2024

  1. Apply suggestions from code review

    Co-authored-by: Rob Wu <[email protected]>
    EmiliaPaz and Rob--W authored Mar 20, 2024
    Configuration menu
    Copy the full SHA
    e8431e9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5267c8c View commit details
    Browse the repository at this point in the history