-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an API proposal for browser.readingList() #420
Conversation
@dlbjames For clarity, what is the status of this API in Chromium? Is Chromium open to discussion and/or iteration on this API design? It looks like the relevant Chromium tracking issue is 1421058 and the relevant feature request is [1238372](https://crbug.com/1238372. This is the relevant Chromium API proposal doc. |
We are very early in the implementation of this API. As such, we are open to some discussion / iteration on the design during implementation. However, after initial implementation, we will be more open to discussion of the design provided the Chromium reading list can support the changes / the discussions do not fundamentally change the feature. I hope the initial version will suffice for the time being (after some comments / light modifications).
Yes, this is all correct! I will add these to the initial comment. Thank you! |
|
Yes they are keyed by URL, and a unique URL can only be part of the reading list once, it can't be added multiple times.
Yes this permission will be optional.
There is currently no way for the reading list entries to be marked as added by a specific extension / action. |
Updates the schema to reflect the current state of implementation on the readingList api
Updated description for url properties with a brief description with what urls are allowed in the reading list. Changes OnEntryWillBeRemoved -> OnEntryRemoved
Hooray, we at Manganum have been waiting for this API for a long time and will implement it as soon as possible. The document and the API itself looks simple and clear. We wait. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to merge
SHA: 98991ac Reason: push, by oliverdunk Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Colleagues, is there any news about when this API may get into the beta and stable channels? |
Oops, apologies for the very delayed response, yankovichv! Short answer: Included in beta some time next week! Since we are targeting chrome version 120, beta promotion (the version that should have the reading list api implemented) will release November 1st. Stable will release on December 5th. More information about the release schedules can be found here: https://chromiumdash.appspot.com/schedule Additionally, in the future for shorter wait times between what we implement and when you can use it, the Canary and Dev versions of chrome receive these updates much faster (I believe Canary is updated 2x a day, and Dev is once a week). 👍 |
Description
Adds an API proposal for the ReadingList feature in the Chromium browser. Covers the background of the problem, and the initial solution / schema for the API.
Note: The Chromium ReadingList uses the URL of the entries as the key, meaning no duplicate URLs are allowed. This may need to be addressed browser to browser depending on how the feature is implemented.
Links
Tracking Issue: 1421058
Feature Request: 1238372
Chromium API Proposal Doc