Better define proxies #964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes a fix where we had omitted "direct" as an option and accidentally included "noproxy" as a proxy type. This closes w3c#837 by ensuring that all entries in the table refer to the valid proxy type for which they should be used. Closes w3c#841, since the URL spec specifies that a host can include credentials. Closes w3c#913 by properly spelling out `noProxy` and when it should be used. Closes w3c#949 by removing the `*ProxyPort` settings, which are not part of the original selenium wire protocol.
AutomatedTester
approved these changes
Jun 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes a fix where we had omitted "direct" as an option
and accidentally included "noproxy" as a proxy type.
This closes #837 by ensuring that all entries in the table
refer to the valid proxy type for which they should be used.
Closes #841, since the URL spec specifies that a host can
include credentials.
Closes #913 by properly spelling out
noProxyand when itshould be used.
Closes #949 by removing the
*ProxyPortsettings, which arenot part of the original selenium wire protocol.
This change is