Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editorial: Use "content navigable" instead of "nested navigable" #1750

Merged

Conversation

rakuco
Copy link
Member

@rakuco rakuco commented Jul 4, 2023

The term was renamed in the HTML spec in whatwg/html#8712 so the current reference was broken as mentioned in #1735.

While here, use ReSpec's shorthand syntax to refer to these sub concepts directly and avoid having to specifically link to them in the index at the end of the document.


Preview | Diff

@rakuco rakuco force-pushed the editorial/fix-nested-navigable-reference branch from d9d74cc to 10153af Compare July 4, 2023 19:22
Copy link
Contributor

@whimboo whimboo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It looks fine to me.

@jgraham any idea why the IPR check is pending? @rakuco is in the w3c group, or is something else needed here to get this PR merged?

@rakuco
Copy link
Member Author

rakuco commented Aug 4, 2023

FWIW, I'm not part of the WG and was hoping this PR could be marked as non-substantive. If not, I can talk to my AC rep and join, but these things always take a while.

@w3cbot
Copy link

w3cbot commented Aug 7, 2023

jgraham marked as non substantive for IPR from ash-nazg.

The term was renamed in the HTML spec in whatwg/html#8712 so the current
reference was broken as mentioned in w3c#1735.

While here, use ReSpec's shorthand syntax to refer to these sub concepts
directly and avoid having to specifically link to them in the index at the
end of the document.
@rakuco rakuco force-pushed the editorial/fix-nested-navigable-reference branch from 10153af to 7679754 Compare August 7, 2023 09:26
@rakuco
Copy link
Member Author

rakuco commented Aug 7, 2023

I've force-pushed to my branch to trigger a new CI run and everything looks fine now that the PR has been marked non-substantive.

@whimboo whimboo merged commit e64e2c8 into w3c:master Aug 7, 2023
1 check passed
@whimboo
Copy link
Contributor

whimboo commented Aug 7, 2023

Thanks @rakuco!

github-actions bot added a commit that referenced this pull request Aug 7, 2023
SHA: e64e2c8
Reason: push, by whimboo

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit to soloinovator/webdriver that referenced this pull request Aug 7, 2023
…#1750)

SHA: e64e2c8
Reason: push, by pull[bot]

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit to xjc90s/webdriver that referenced this pull request Aug 7, 2023
…#1750)

SHA: e64e2c8
Reason: push, by pull[bot]

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit to ZRDKPoWeR/webdriver that referenced this pull request Aug 8, 2023
…#1750)

SHA: e64e2c8
Reason: push, by pull[bot]

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants