-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an ability to locate nodes using computed accessibility attributes #660
Conversation
87505eb
to
317d179
Compare
317d179
to
552cfdb
Compare
@sadym-chromium PTAL |
@jrandolf PTAL |
279dfcc
to
fbb29aa
Compare
fbb29aa
to
3a6a2ce
Compare
3a6a2ce
to
3bb538e
Compare
e783b97
to
94cc3dc
Compare
The Browser Testing and Tools Working Group just discussed The full IRC log of that discussion<AutomatedTester_> topic: Add an ability to locate nodes using computed accessibility attributes<AutomatedTester_> github: https://github.com//pull/660 <AutomatedTester_> orkon: this is a feature used in puppeteer and wanted to check if there are concerns? <AutomatedTester_> jgraham1: I don;t think so, I think the approval just slipped through the cracks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be very helpful for WebdriverIO not have to create weird xpath selectors that aren't 100% correct all the time
👍
@OrKoN, are you planning to add wpt tests for it, once the spec is merged? |
@lutien yes |
Co-authored-by: jgraham <[email protected]>
Co-authored-by: jgraham <[email protected]>
Co-authored-by: jgraham <[email protected]>
Co-authored-by: jgraham <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But note the small fixup required.
Co-authored-by: jgraham <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me as well now. Thanks.
Based on: #624
Issue: #443
Preview | Diff