Explicitly set CryptoKey.type to "secret" in AES and HMAC operations #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are strongly suggested to be 'secret' anyway, per this description: https://w3c.github.io/webcrypto/#dom-keytype However, it seems wiser to define this explicitly, instead of hoping for the best.
These are strongly suggested to be 'secret' anyway, per this description: https://w3c.github.io/webcrypto/#dom-keytype However, it seems wiser to define this explicitly, instead of hoping for the best.
BenWiederhake
force-pushed
the
dev-cryptokey-fields
branch
from
48ec43e
to
e8e4655
Compare
|
Ah, I'm not part of the "Web Application Security Working Group", and as such, the IPR-bot refuses to acknowledge me. Makes sense. This PR is a non-substantive change because it contains "Changes that do not functionally affect interpretation of the document" https://www.w3.org/policies/process/#class-2 |
|
BenWiederhake marked as non substantive for IPR from ash-nazg. |
twiss
approved these changes
Oct 25, 2024
There was a problem hiding this comment.
👍 Thanks!
For the future, you should be able to join the WebAppSec WG just by clicking a button on https://www.w3.org/groups/wg/webappsec/, I think :)
|
Fantastic! I thought that surely with such a long and important name there would be a long list of requirements and such. Good to know, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #376
This maps de-facto behavior of most (if not all) implementors, and is already strongly suggested by other parts of the spec: https://w3c.github.io/webcrypto/#dom-keytype
This is already tested as part of WPT: https://github.com/web-platform-tests/wpt/blob/272064ebf9a3d313a2d4db8bb9ce2790648aa162/WebCryptoAPI/generateKey/successes.js#L70
Preview | Diff