Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #146: Specify source of data for eliptic curve key import and fix… #148

Merged
merged 1 commit into from
Oct 18, 2016
Merged

Fix #146: Specify source of data for eliptic curve key import and fix… #148

merged 1 commit into from
Oct 18, 2016

Conversation

mwatson2
Copy link
Collaborator

… error type

@mwatson2 mwatson2 mentioned this pull request Sep 13, 2016
Closed
@jimsch
Copy link
Contributor

jimsch commented Sep 17, 2016

If this is to be data error, should it just only do one format rather than must do one and may do the other?

@mwatson2
Copy link
Collaborator Author

We use DataError universally to indicate that the method failed because of the contents of the provided key data. I think it's fine that one of the formats is optional.

@mwatson2 mwatson2 merged commit e094c89 into w3c:master Oct 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ware ware ware approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mwatson2 @jimsch @ware