Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Several algorithms unnecessarily check that a provided hash is supported #119

Closed
mwatson2 opened this issue Jul 11, 2016 · 1 comment
Closed

Several algorithms unnecessarily check that a provided hash is supported #119

mwatson2 opened this issue Jul 11, 2016 · 1 comment
Assignees
@mwatson2

Comments

@mwatson2
Copy link
Collaborator

mwatson2 commented Jul 11, 2016 •
edited
Loading

For example, ECDSA sign / verify have the following step:

If hashAlgorithm does not describe a registered algorithm that supports the digest operation, then throw a NotSupportedError.

However, this will have been checked during algorithm normalization and so the check is redundant here.
@mwatson2 mwatson2 self-assigned this Jul 12, 2016
@mwatson2 mwatson2 changed the title ECDSA unnecessarily checks that the provided hash is valid in sign/verify Several algorithms unnecessarily check that a provided hash Jul 12, 2016
mwatson2 added a commit to mwatson2/webcrypto that referenced this issue Jul 12, 2016
@mwatson2
Fix w3c#119: Remove redundant checks that hash algorithm is supported
8fc1ef6
@mwatson2
Copy link
Collaborator Author

PR #123

@mwatson2 mwatson2 changed the title Several algorithms unnecessarily check that a provided hash Several algorithms unnecessarily check that a provided hash is supported Jul 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mwatson2 mwatson2

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mwatson2