Extend EncodedVideoChunkMetadata #636
Conversation
Fix for Issue #619
|
@Djuffin to review. |
| @@ -1692,6 +1711,11 @@ | |||
|
|
|||
| dictionary SvcOutputMetadata { | |||
| unsigned long temporalLayerId; | |||
| unsigned long spatiallayerId; | |||
| unsigned short frameNumber; | |||
There was a problem hiding this comment.
Why not frameId like in RTCEncodedVideoFrameMetadata ?
There was a problem hiding this comment.
As noted in the Dependency Descriptor specification section A.8.3, frame_number is not the same as FrameId.
| @@ -1692,6 +1711,11 @@ | |||
|
|
|||
| dictionary SvcOutputMetadata { | |||
| unsigned long temporalLayerId; | |||
| unsigned long spatiallayerId; | |||
| unsigned short frameNumber; | |||
| sequence<unsigned long> dependsOnIds; | |||
There was a problem hiding this comment.
Why not dependencies like in RTCEncodedVideoFrameMetadata?
There was a problem hiding this comment.
dependencies in RTCEncodedVideoFrameMetadata is not defined but I'm assuming it is a sequence of frameId values. dependsOnIds is a sequence of frameNumber values (though it seems odd that frameNumber is an unsigned short and dependsOnIds is a sequence of unsigned long values).
There was a problem hiding this comment.
Shouldn't it be names dependsOnFrameNumbers then?
Otherwise LGTM.
Fixes #619
💥 Error: 400 Bad Request 💥
PR Preview failed to build. (Last tried on Mar 16, 2023, 3:22 AM UTC).
More
PR Preview relies on a number of web services to run. There seems to be an issue with the following one:
🚨 CSS Spec Preprocessor - CSS Spec Preprocessor is the web service used to build Bikeshed specs.
🔗 Related URL
If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.