Specify the supported hashing algorithms. #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given that we haven't changed the supported algorithms in almost a decade, it seems reasonable to lock them in and define their ordering rather than deferring to the user agent. If we add new algorithms in the future, this specificity will make it simpler to reason about how those algorithms fit into the system. This is not strictly an editorial change, as it does introduce new requirements for user agents. Practically, however, it only encodes the status quo, and will not result in any change in existing tests or behavior. Also: this closes #106 via an adjusted note in a section the patch was touching anyway.
|
One more you might have time to look at, @mozfreddyb? |
|
cc @baek9 |
mozfreddyb
approved these changes
Oct 10, 2024
github-actions bot
added a commit
that referenced
this pull request
Oct 10, 2024
SHA: abca59a Reason: push, by mikewest Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that we haven't changed the supported algorithms in almost a decade, it seems reasonable to lock them in and define their ordering rather than deferring to the user agent.
If we add new algorithms in the future, this specificity will make it simpler to reason about how those algorithms fit into the system.
This is not strictly an editorial change, as it does introduce new requirements for user agents. Practically, however, it only encodes the status quo, and will not result in any change in existing tests or behavior.
Also: this closes #106 via an adjusted note in a section the patch was touching anyway.
Preview | Diff