Editorial updates #125
Merged
Editorial updates #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating links in a few ways, none of which (intentionally) change normative meaning: 1. Linking to HTML, not HTML5. 2. Dropping hard-coded links that are now properly exported. 3. Updating grammar to link to CSP.
Rather than linking to (very) old implementation reports, we can instead render live data from WPT instead.
This patch cleans up example code by using `<xmp>` instead of `<pre>` to make things more readable, and by adding syntax highlighting.
If we'd like to support non-hash algorithms, changing variable names in the parsing function will reduce the complexity of future diffs.
|
Personally, I don't believe the new variable names in the algorithm are more useful, but I will admit that the previous once weren't better. Thank you for all of the changes. It's nice that we can have syntax highlighting now :) |
github-actions bot
added a commit
that referenced
this pull request
Oct 10, 2024
SHA: 0f7980a Reason: push, by mozfreddyb Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
They'll make the diff in https://wicg.github.io/signature-based-sri/#parsing simpler. :) Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR pulls together some small editorial updates that remove hard-coded links (thereby shifting to Infra and HTML in some places), and adjusts some variable names for future extensibility. Nothing crazy.
I've broken the changes out into a few distinct commits in the hopes that that makes this simpler to review.
WDYT, @mozfreddyb?
Preview | Diff