-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broken links and wrong definitions used #33
Comments
Thanks for the review and the bug reports. I'll get these taken care of! |
This patch addresses the first ~half of the comments in #33, focusing on clarity around the usage of 'environment settings objects' and 'global object', as well as various and sundry ways of getting to both. Additionally, it moves to new terminology around origins, and cleans up the document's references a little bit. Not done, but a good first step.
Just about everything here is done. There's an outstanding issue against Bikeshed for the WebIDL reference, and an open PR against HTML to upstream the Thanks again for the review, @domenic! |
I think this is all taken care of/upstreamed now, with the exception of the WebIDL reference. |
I noticed the following in a quick review:
Document
object, which is not a global object. This should instead be "relevant settings object" which is more general.The text was updated successfully, but these errors were encountered: