Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comparison does not seem to account for opaque origins #41

Closed
annevk opened this issue Sep 11, 2019 · 0 comments · Fixed by #42
Closed

Comparison does not seem to account for opaque origins #41

annevk opened this issue Sep 11, 2019 · 0 comments · Fixed by #42

Comments

@annevk
Copy link
Member

annevk commented Sep 11, 2019

At least, the text I read in 4316583 seems to assume the origin has a scheme, which isn't always a given.
@annevk annevk mentioned this issue Sep 11, 2019
Closed
mikewest added a commit that referenced this issue Sep 11, 2019
@mikewest
Sec-Fetch-Site's scheme comparison should account for opaque origins.
7e41283 
Thanks, @annevk. Closes #41.
@mikewest mikewest mentioned this issue Sep 11, 2019
Merged
mikewest added a commit that referenced this issue Sep 13, 2019
@mikewest
Sec-Fetch-Site's scheme comparison should account for opaque origins. (…
274ab84 
…#42)

This patch also shifts away from using "registrable domain" directly, and instead defers
to URL's definition of "same site" for hosts.

Thanks to @annevk. Closes #41.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Sec-Fetch-Site's scheme comparison should account for opaque origins. w3c/webappsec-fetch-metadata
1 participant
@annevk