Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define with types are allowed in the same get() request #261

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Define with types are allowed in the same get() request #261

wants to merge 10 commits into from

Conversation

mohamedamir
Copy link

@mohamedamir mohamedamir commented Sep 20, 2024 •
edited by pr-preview bot
Loading

Issue #244

(Remove the following for non-normative changes)

The following tasks have been completed:

  • Modified Web platform tests (link to pull request)

Implementation commitment:

Preview | Diff

nsatragno
nsatragno reviewed Sep 20, 2024
View reviewed changes
Copy link
Member

@nsatragno nsatragno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Please address the bikeshed errors as well.

index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
@nsatragno nsatragno added the type:technical Technical issues or features label Sep 20, 2024
@mohamedamir mohamedamir marked this pull request as ready for review September 20, 2024 15:58
@mohamedamir mohamedamir marked this pull request as draft September 20, 2024 15:58
@mohamedamir mohamedamir marked this pull request as ready for review September 20, 2024 15:58
nsatragno
nsatragno reviewed Sep 20, 2024
View reviewed changes
Copy link
Member

@nsatragno nsatragno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, with some comments. Could you update WPTs and file bugs against the different browsers so we can track the implementation? Thanks!

index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
mohamedamir and others added 5 commits September 20, 2024 12:21
@mohamedamir @nsatragno
Update index.bs
560f360 
Co-authored-by: Nina Satragno <[email protected]>
@mohamedamir @nsatragno
Update index.bs
403cf0c 
Co-authored-by: Nina Satragno <[email protected]>
@mohamedamir @nsatragno
Update index.bs
abd9c2f 
Co-authored-by: Nina Satragno <[email protected]>
@mohamedamir @nsatragno
Update index.bs
64451ca 
Co-authored-by: Nina Satragno <[email protected]>
@mohamedamir
fix =set/contain=
bdb66e8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nsatragno nsatragno nsatragno left review comments

@marcoscaceres marcoscaceres Awaiting requested review from marcoscaceres

Assignees

@mohamedamir mohamedamir

Labels
type:technical Technical issues or features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mohamedamir @nsatragno